Re: [RFC PATCH 03/16] x86/boot: Public getting random boot function

2015-07-31 Thread Pavel Machek
On Fri 2015-07-31 18:52:09, joeyli wrote: > On Tue, Jul 28, 2015 at 02:21:33PM +0200, Pavel Machek wrote: > > Hi! > > > > > int cmdline_find_option_bool(const char *option); > > > #endif > > > > > > +#if CONFIG_RANDOMIZE_BASE > > > > Not ifdef? > > > > > +extern u16 i8254(void); > > > > Tha

Re: [RFC PATCH 03/16] x86/boot: Public getting random boot function

2015-07-31 Thread joeyli
On Tue, Jul 28, 2015 at 02:21:33PM +0200, Pavel Machek wrote: > Hi! > > > int cmdline_find_option_bool(const char *option); > > #endif > > > > +#if CONFIG_RANDOMIZE_BASE > > Not ifdef? > > > +extern u16 i8254(void); > > That's rather poor name for global function... This i8254 function onl

Re: [RFC PATCH 03/16] x86/boot: Public getting random boot function

2015-07-28 Thread Pavel Machek
Hi! > int cmdline_find_option_bool(const char *option); > #endif > > +#if CONFIG_RANDOMIZE_BASE Not ifdef? > +extern u16 i8254(void); That's rather poor name for global function... > #if CONFIG_RANDOMIZE_BASE Ok, maybe not, but I'm confused.