Re: [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support

2019-07-30 Thread Anup Patel
On Tue, Jul 30, 2019 at 2:53 PM Paolo Bonzini wrote: > > On 29/07/19 13:56, Anup Patel wrote: > > + case KVM_CAP_DEVICE_CTRL: > > + case KVM_CAP_USER_MEMORY: > > + case KVM_CAP_SYNC_MMU: > > Technically KVM_CAP_SYNC_MMU should only be added after you add MMU > notifiers. Sure, I will

Re: [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support

2019-07-30 Thread Anup Patel
On Tue, Jul 30, 2019 at 2:55 PM Paolo Bonzini wrote: > > On 29/07/19 13:56, Anup Patel wrote: > > +void kvm_riscv_halt_guest(struct kvm *kvm) > > +{ > > + int i; > > + struct kvm_vcpu *vcpu; > > + > > + kvm_for_each_vcpu(i, vcpu, kvm) > > + vcpu->arch.pause = true; > > +

Re: [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support

2019-07-30 Thread Paolo Bonzini
On 29/07/19 13:56, Anup Patel wrote: > +void kvm_riscv_halt_guest(struct kvm *kvm) > +{ > + int i; > + struct kvm_vcpu *vcpu; > + > + kvm_for_each_vcpu(i, vcpu, kvm) > + vcpu->arch.pause = true; > + kvm_make_all_cpus_request(kvm, KVM_REQ_SLEEP); > +} > + > +void kvm_risc

Re: [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support

2019-07-30 Thread Paolo Bonzini
On 29/07/19 13:56, Anup Patel wrote: > + case KVM_CAP_DEVICE_CTRL: > + case KVM_CAP_USER_MEMORY: > + case KVM_CAP_SYNC_MMU: Technically KVM_CAP_SYNC_MMU should only be added after you add MMU notifiers. Paolo > + case KVM_CAP_DESTROY_MEMORY_REGION_WORKS: > + case KVM_CAP_ONE_