Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-12 Thread Tomi Valkeinen
On 12/02/14 07:02, Ryan Mallon wrote: > Well, the alternative is to supply an fb_write() implementation for each > driver that calls fb_sys_write(), and then updates the display. The > fb_sync() additions can be removed. That would cut down the boiler-plate > code, and should keep the behaviour th

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Ryan Mallon
On 12/02/14 19:54, Tomi Valkeinen wrote: > On 11/02/14 21:07, Ryan Mallon wrote: >> On 12/02/14 03:06, Tomi Valkeinen wrote: >> >>> On 20/09/13 10:06, Ryan Mallon wrote: Several video drivers open code the fb_write write function with code which is very similar to fb_sys_write. Replace t

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Tomi Valkeinen
On 11/02/14 21:07, Ryan Mallon wrote: > On 12/02/14 03:06, Tomi Valkeinen wrote: > >> On 20/09/13 10:06, Ryan Mallon wrote: >>> Several video drivers open code the fb_write write function with code >>> which is very similar to fb_sys_write. Replace the open code versions >>> with calls to fb_sys_w

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Ryan Mallon
On 12/02/14 03:06, Tomi Valkeinen wrote: > On 20/09/13 10:06, Ryan Mallon wrote: >> Several video drivers open code the fb_write write function with code >> which is very similar to fb_sys_write. Replace the open code versions >> with calls to fb_sys_write. An fb_sync callback is added to each of

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Tomi Valkeinen
On 20/09/13 10:06, Ryan Mallon wrote: > Several video drivers open code the fb_write write function with code > which is very similar to fb_sys_write. Replace the open code versions > with calls to fb_sys_write. An fb_sync callback is added to each of > the drivers. > > Signed-off-by: Ryan Mal