Re: [RFC PATCH] sched: fix hierarchical order in rq->leaf_cfs_rq_list

2016-06-02 Thread Vincent Guittot
On 1 June 2016 at 19:42, wrote: > Peter Zijlstra writes: > >> On Tue, May 24, 2016 at 11:55:10AM +0200, Vincent Guittot wrote: >>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >>> index 218f8e8..6d3fbf2 100644 >>> --- a/kernel/sched/fair.c >>> +++ b/kernel/sched/fair.c >>> @@ -290,15 +

Re: [RFC PATCH] sched: fix hierarchical order in rq->leaf_cfs_rq_list

2016-06-01 Thread bsegall
Peter Zijlstra writes: > On Tue, May 24, 2016 at 11:55:10AM +0200, Vincent Guittot wrote: >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 218f8e8..6d3fbf2 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -290,15 +290,31 @@ static inline void list_add_leaf_

Re: [RFC PATCH] sched: fix hierarchical order in rq->leaf_cfs_rq_list

2016-06-01 Thread Peter Zijlstra
On Tue, May 24, 2016 at 11:55:10AM +0200, Vincent Guittot wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 218f8e8..6d3fbf2 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -290,15 +290,31 @@ static inline void list_add_leaf_cfs_rq(struct cfs_rq > *cfs_rq)

Re: [RFC PATCH] sched: fix hierarchical order in rq->leaf_cfs_rq_list

2016-05-26 Thread Vincent Guittot
On 25 May 2016 at 19:40, Dietmar Eggemann wrote: > Hi Vincent, > > On 24/05/16 10:55, Vincent Guittot wrote: >> Fix the insertion of cfs_rq in rq->leaf_cfs_rq_list to ensure that >> a child will always called before its parent. >> >> The hierarchical order in shares update list has been introduced

Re: [RFC PATCH] sched: fix hierarchical order in rq->leaf_cfs_rq_list

2016-05-25 Thread Dietmar Eggemann
Hi Vincent, On 24/05/16 10:55, Vincent Guittot wrote: > Fix the insertion of cfs_rq in rq->leaf_cfs_rq_list to ensure that > a child will always called before its parent. > > The hierarchical order in shares update list has been introduced by > commit 67e86250f8ea ("sched: Introduce hierarchal or