Re: [RFC PATCH] makefile: add debug option to enable function aligned on 32 bytes

2020-07-23 Thread Feng Tang
On Thu, Jul 23, 2020 at 05:57:04PM -0700, Andrew Morton wrote: > On Thu, 23 Jul 2020 14:29:33 +0800 Feng Tang wrote: > > > > > gcc has an option '-falign-functions=n' to force text aligned, and with > > > > that option enabled, some of those performance changes will be gone, > > > > like [1][2][3

Re: [RFC PATCH] makefile: add debug option to enable function aligned on 32 bytes

2020-07-23 Thread Andrew Morton
On Thu, 23 Jul 2020 14:29:33 +0800 Feng Tang wrote: > > > gcc has an option '-falign-functions=n' to force text aligned, and with > > > that option enabled, some of those performance changes will be gone, > > > like [1][2][3]. > > > > > > Add this option so that developers and 0day can easily fi

Re: [RFC PATCH] makefile: add debug option to enable function aligned on 32 bytes

2020-07-22 Thread Feng Tang
On Wed, Jul 22, 2020 at 08:39:19PM -0700, Andrew Morton wrote: > On Thu, 23 Jul 2020 11:30:01 +0800 Feng Tang wrote: > > > Recently 0day reported many strange performance changes (regression > > or improvement), in which there was no obvious relation between > > the culprit commit and the benchma

Re: [RFC PATCH] makefile: add debug option to enable function aligned on 32 bytes

2020-07-22 Thread Feng Tang
Hi Andrew, Thanks for the review. On Wed, Jul 22, 2020 at 08:39:19PM -0700, Andrew Morton wrote: > On Thu, 23 Jul 2020 11:30:01 +0800 Feng Tang wrote: > > > Recently 0day reported many strange performance changes (regression > > or improvement), in which there was no obvious relation between >

Re: [RFC PATCH] makefile: add debug option to enable function aligned on 32 bytes

2020-07-22 Thread Andrew Morton
On Thu, 23 Jul 2020 11:30:01 +0800 Feng Tang wrote: > Recently 0day reported many strange performance changes (regression > or improvement), in which there was no obvious relation between > the culprit commit and the benchmark at the first look, and it causes > people to doubt the test itself is