Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Greg KH
On Mon, Oct 07, 2013 at 12:18:43PM -0700, Josh Triplett wrote: > The 80-character limit is not a hard-and-fast rule, nor should it be > applied blindly by people running checkpatch and fixing its warnings. > Sometimes it's better to violate the 80-character "limit" in the name of > readability, and

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Josh Triplett
On Mon, Oct 07, 2013 at 12:38:20PM -0700, Joe Perches wrote: > On Mon, 2013-10-07 at 12:34 -0700, Josh Triplett wrote: > > On Mon, Oct 07, 2013 at 12:28:26PM -0700, Joe Perches wrote: > > > On Mon, 2013-10-07 at 12:18 -0700, Josh Triplett wrote: > > > > The 80-character limit is not a hard-and-fast

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Joe Perches
On Mon, 2013-10-07 at 14:33 -0700, Joe Perches wrote: > On Mon, 2013-10-07 at 22:23 +0100, Al Viro wrote: > > On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote: > > > > > I've seen far more examples of the 80-column limit making code less > > > readable rather than more. It's only rea

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Andi Kleen
Josh Triplett writes: > The 80-character limit is not a hard-and-fast rule, nor should it be > applied blindly by people running checkpatch and fixing its warnings. > Sometimes it's better to violate the 80-character "limit" in the name of > readability, and when it isn't, it's often better to re

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Joe Perches
On Mon, 2013-10-07 at 22:23 +0100, Al Viro wrote: > On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote: > > > I've seen far more examples of the 80-column limit making code less > > readable rather than more. It's only really helpful when it forces code > > restructuring, *not* when it

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Al Viro
On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote: > I've seen far more examples of the 80-column limit making code less > readable rather than more. It's only really helpful when it forces code > restructuring, *not* when it just forces an arbitrary line break. So teach that piece o

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Richard Weinberger
On Mon, Oct 7, 2013 at 9:18 PM, Josh Triplett wrote: > The 80-character limit is not a hard-and-fast rule, nor should it be > applied blindly by people running checkpatch and fixing its warnings. > Sometimes it's better to violate the 80-character "limit" in the name of > readability, and when it

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Joe Perches
On Mon, 2013-10-07 at 12:34 -0700, Josh Triplett wrote: > On Mon, Oct 07, 2013 at 12:28:26PM -0700, Joe Perches wrote: > > On Mon, 2013-10-07 at 12:18 -0700, Josh Triplett wrote: > > > The 80-character limit is not a hard-and-fast rule, nor should it be > > > applied blindly by people running check

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Josh Triplett
On Mon, Oct 07, 2013 at 12:28:26PM -0700, Joe Perches wrote: > On Mon, 2013-10-07 at 12:18 -0700, Josh Triplett wrote: > > The 80-character limit is not a hard-and-fast rule, nor should it be > > applied blindly by people running checkpatch and fixing its warnings. > > Sometimes it's better to viol

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Joe Perches
On Mon, 2013-10-07 at 12:18 -0700, Josh Triplett wrote: > The 80-character limit is not a hard-and-fast rule, nor should it be > applied blindly by people running checkpatch and fixing its warnings. > Sometimes it's better to violate the 80-character "limit" in the name of > readability, and when i