Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-05 Thread Srinivas Pandruvada
Hi Hans, [...] > So digging a bit deeper I just realized that another important > difference > between med_power_with_dipm and min_power is that min_power by > default > set the ASP bits making the link go to the slumber state instead of > to > the partial (power-saving) state. > > According to

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-03 Thread Hans de Goede
Hi, On 03-07-18 10:57, Hans de Goede wrote: Hi, On 03-07-18 00:08, Srinivas Pandruvada wrote: Hi Hans, On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: SATA IP block doesn't get turned off till SATA is in DEVSLP mode. Here user has to either use scsi-host sysfs or tools like power

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-03 Thread Hans de Goede
Hi, On 03-07-18 00:08, Srinivas Pandruvada wrote: Hi Hans, On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: SATA IP block doesn't get turned off till SATA is in DEVSLP mode. Here user has to either use scsi-host sysfs or tools like powertop to set the sata-host link_power_management

RE: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Mario.Limonciello
.kernel.org; linux...@vger.kernel.org; Limonciello, Mario > Subject: Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern > standby platform > > Hi Hans, > > On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: > > Hi, > > > > On 02-07-18 22:21, Tejun Heo

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Srinivas Pandruvada
Hi Hans, On Mon, 2018-07-02 at 23:27 +0200, Hans de Goede wrote: > Hi, > > On 02-07-18 22:21, Tejun Heo wrote: > > On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada > > wrote: > > > From: Srinivas > > > > > > One of the requirement for modern x86 system to enter lowest > > > power m

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Hans de Goede
Hi, On 02-07-18 22:21, Tejun Heo wrote: On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada wrote: From: Srinivas One of the requirement for modern x86 system to enter lowest power mode (SLP_S0) is SATA IP block to be off. This is true even during when platform is suspended to idle

Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Tejun Heo
On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada wrote: > From: Srinivas > > One of the requirement for modern x86 system to enter lowest power mode > (SLP_S0) is SATA IP block to be off. This is true even during when > platform is suspended to idle and not only in opportunistic (run