Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-22 Thread Borislav Petkov
On Tue, Sep 22, 2020 at 10:03:03AM +0200, Thomas Gleixner wrote: > On Sun, Sep 20 2020 at 17:42, Borislav Petkov wrote: > > Hi, > > > > so tglx hates this clearcpuid= interface where you have to give the > > X86_FEATURE array indices in order to disable a feature bit for testing. > > Below is a fir

Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-22 Thread Thomas Gleixner
On Sun, Sep 20 2020 at 17:42, Borislav Petkov wrote: > Hi, > > so tglx hates this clearcpuid= interface where you have to give the > X86_FEATURE array indices in order to disable a feature bit for testing. > Below is a first attempt (lightly tested in a VM only) to accept the bit > names from /proc

Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-20 Thread Borislav Petkov
On Sun, Sep 20, 2020 at 02:35:27PM -0400, Arvind Sankar wrote: > Thanks. Maybe also mention in the documentation that names can now be > used. Already did it as an incremental ontop. Will merge later: --- diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/ke

Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-20 Thread Arvind Sankar
On Sun, Sep 20, 2020 at 07:29:54PM +0200, Borislav Petkov wrote: > On Sun, Sep 20, 2020 at 12:16:28PM -0400, Arvind Sankar wrote: > > Allowing 13:24 as input would be icing on the cake :) > > Well, I'm kinda "meh" on that. Why, you ask? > > Well, whether the user multiplies two integers or the ke

Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-20 Thread Borislav Petkov
On Sun, Sep 20, 2020 at 12:16:28PM -0400, Arvind Sankar wrote: > Allowing 13:24 as input would be icing on the cake :) Well, I'm kinda "meh" on that. Why, you ask? Well, whether the user multiplies two integers or the kernel does it for her/him, I'd prefer the user. But that's not even the probl

Re: [RFC PATCH] Use feature bit names in clearcpuid=

2020-09-20 Thread Arvind Sankar
On Sun, Sep 20, 2020 at 05:42:28PM +0200, Borislav Petkov wrote: > Hi, > > so tglx hates this clearcpuid= interface where you have to give the > X86_FEATURE array indices in order to disable a feature bit for testing. > Below is a first attempt (lightly tested in a VM only) to accept the bit > nam