Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-06-05 Thread Ingo Molnar
* Alexander Shishkin wrote: > @@ -300,6 +300,7 @@ struct pmu { > * struct pmu::capabilities flags > */ > #define PERF_PMU_CAP_NO_INTERRUPT1 > +#define PERF_PMU_CAP_AUX_BROKEN_SG 2 Btw., I'd name it PERF_PMU_AUX_PHYSICAL_SG or so, and add a comment before it that explains that such h

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-21 Thread Alexander Shishkin
Peter Zijlstra writes: > On Mon, May 19, 2014 at 03:57:37PM +0300, Alexander Shishkin wrote: >> Peter Zijlstra writes: > >> > I'm not entirely thrilled to expose it to the PMU like this.. I realize >> > you want this in order to get physically contiguous pages. >> >> Hmm, I guess we can have co

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-20 Thread Peter Zijlstra
On Mon, May 19, 2014 at 03:57:37PM +0300, Alexander Shishkin wrote: > Peter Zijlstra writes: > > I'm not entirely thrilled to expose it to the PMU like this.. I realize > > you want this in order to get physically contiguous pages. > > Hmm, I guess we can have code in perf core to carry out the

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-19 Thread Alexander Shishkin
Peter Zijlstra writes: > On Thu, May 15, 2014 at 06:08:30PM +0300, Alexander Shishkin wrote: >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -252,6 +252,19 @@ struct pmu { >> * flush branch stack on context-switches (needed in cpu-wide mode) >> */ >>

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-19 Thread Peter Zijlstra
On Thu, May 15, 2014 at 06:08:30PM +0300, Alexander Shishkin wrote: > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -252,6 +252,19 @@ struct pmu { >* flush branch stack on context-switches (needed in cpu-wide mode) >*/ > void (*flush_branch_stack)

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-16 Thread Alexander Shishkin
Robert Richter writes: > On 15.05.14 18:08:30, Alexander Shishkin wrote: >> From: Peter Zijlstra >> >> This patch introduces "AUX space" in the perf mmap buffer, intended for >> exporting high bandwidth data streams to userspace, such as instruction >> flow traces. >> >> AUX space is a ring bu

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-15 Thread Robert Richter
On 15.05.14 18:08:30, Alexander Shishkin wrote: > From: Peter Zijlstra > > This patch introduces "AUX space" in the perf mmap buffer, intended for > exporting high bandwidth data streams to userspace, such as instruction > flow traces. > > AUX space is a ring buffer, defined by aux_{offset,size}