Re: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors

2007-05-06 Thread Satyam Sharma
On 5/7/07, Bert Wesarg <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: > + if (ctor || dtor) { > + so = kzalloc(sizeof(struct slab_ops), GFP_KERNEL); > + so->ctor = ctor; > + so->dtor = dtor; > + } > + return __kmem_cache_create(s, size, align,

Re: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors

2007-05-06 Thread Bert Wesarg
[EMAIL PROTECTED] wrote: > + if (ctor || dtor) { > + so = kzalloc(sizeof(struct slab_ops), GFP_KERNEL); > + so->ctor = ctor; > + so->dtor = dtor; > + } > + return __kmem_cache_create(s, size, align, flags, so); Is this a memory leak? Regards Bert We

Re: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors

2007-05-05 Thread Pekka Enberg
On 5/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: This patch gets rid constructors and destructors and replaces them with a slab operations structure that is passed into SLUB. Looks good to me. On 5/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: +struct slab_ops { + /* FIXME:

Re: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors

2007-05-05 Thread Christoph Lameter
On Sat, 5 May 2007, Pekka Enberg wrote: > For consistency with other operations structures, can we make this > struct kmem_cache_operations or kmem_cache_ops, please? Ok. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More