Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-21 Thread Hans de Goede
Hi, On 21-08-17 13:43, Hans de Goede wrote: I'm also thinking that under Linux since we never use userspace to alloc memory for the balloon, we don't need to involve userspace at all, the drivers interrupt handler could detect the event that the host wants to change the balloonsize itself and

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-21 Thread Hans de Goede
Hi, On 14-08-17 14:15, Hans de Goede wrote: Hi, On 14-08-17 11:30, Arnd Bergmann wrote: On Sat, Aug 12, 2017 at 11:56 PM, Hans de Goede wrote: On 11-08-17 23:23, Arnd Bergmann wrote: On Fri, Aug 11, 2017 at 3:23 PM, Hans de Goede wrote: Most of the issues I would normally comment on are al

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-14 Thread Hans de Goede
Hi, On 14-08-17 11:30, Arnd Bergmann wrote: On Sat, Aug 12, 2017 at 11:56 PM, Hans de Goede wrote: On 11-08-17 23:23, Arnd Bergmann wrote: On Fri, Aug 11, 2017 at 3:23 PM, Hans de Goede wrote: Most of the issues I would normally comment on are already moot based on the assumption that we won

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-14 Thread Arnd Bergmann
On Sat, Aug 12, 2017 at 11:56 PM, Hans de Goede wrote: > On 11-08-17 23:23, Arnd Bergmann wrote: >> On Fri, Aug 11, 2017 at 3:23 PM, Hans de Goede >> wrote: >> Most of the issues I would normally comment on are already moot based >> on the assumption that we won't be able to make substantial chan

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-14 Thread Hans de Goede
Hi, On 12-08-17 23:56, Hans de Goede wrote: On 11-08-17 23:23, Arnd Bergmann wrote: +/** + * @name VBoxGuest IOCTL codes and structures. + * + * The range 0..15 is for basic driver communication. + * The range 16..31 is for HGCM communication. + * The range 32..47 is reserved for future use

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-12 Thread Greg Kroah-Hartman
On Sat, Aug 12, 2017 at 11:56:22PM +0200, Hans de Goede wrote: > > 'u32' is not an approprioate type for a kernel header, use '__u32' > > instead. > > Huh I thought that u32 was preferred, but I guess that it is not allowed > in uapi headers due to potential conflicts and it should be __u32 in uap

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-12 Thread Hans de Goede
Hi, On 11-08-17 23:23, Arnd Bergmann wrote: On Fri, Aug 11, 2017 at 3:23 PM, Hans de Goede wrote: This commit adds a driver for the Virtual Box Guest PCI device used in Virtual Box virtual machines. Enabling this driver will add support for Virtual Box Guest integration features such as copy-a

Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration

2017-08-11 Thread Arnd Bergmann
On Fri, Aug 11, 2017 at 3:23 PM, Hans de Goede wrote: > This commit adds a driver for the Virtual Box Guest PCI device used in > Virtual Box virtual machines. Enabling this driver will add support for > Virtual Box Guest integration features such as copy-and-paste, seamless > mode and OpenGL pass-