Re: [RFC] regmap: change bool to 1 bit variable in struct regmap

2015-10-08 Thread Pavel Machek
On Thu 2015-10-08 12:24:02, yalin wang wrote: > This patch change some bool variables in struct regmap { } > to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap. Are there any atomicity/locking implications? -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [RFC] regmap: change bool to 1 bit variable in struct regmap

2015-10-08 Thread Mark Brown
On Thu, Oct 08, 2015 at 04:42:42PM +0800, yalin wang wrote: > i also found lots of code use this wrong coding style by search source code : > $ egrep -H ' : [0-9]+' `find . -name *.h` | grep -v '?' > ~/result.txt Mostly old and/or obscure code, or code that's shared with other things. signat

Re: [RFC] regmap: change bool to 1 bit variable in struct regmap

2015-10-08 Thread yalin wang
ok, i will send V2 patch > On Oct 8, 2015, at 16:15, Mark Brown wrote: > > On Thu, Oct 08, 2015 at 12:24:02PM +0800, yalin wang wrote: > >> +u8 async : 1, > > Please use the kernel coding style, no spaces around the :. -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [RFC] regmap: change bool to 1 bit variable in struct regmap

2015-10-08 Thread Mark Brown
On Thu, Oct 08, 2015 at 12:24:02PM +0800, yalin wang wrote: > + u8 async : 1, Please use the kernel coding style, no spaces around the :. signature.asc Description: Digital signature