Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-17 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 17, 2019 at 10:25:24AM +, Nick Clifton escreveu: > Hi Arnaldo, > > >>> Humm, is -fno-omit-frame-pointer there by any chance? :-) > > > Would be interestint to have that info, as we could hint the user that > > backtraces should be done with something else than '--call-graph fp' :-

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-17 Thread Nick Clifton
Hi Arnaldo, >>> Humm, is -fno-omit-frame-pointer there by any chance? :-) > Would be interestint to have that info, as we could hint the user that > backtraces should be done with something else than '--call-graph fp' :-) OK, well I have added the feature to annobin 8.67, now in Fedora rawhide.

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-16 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 16, 2019 at 03:47:50PM +, Nick Clifton escreveu: > Hi Arnaldo, > > >> Unfortunately the annobin notes will probably not be very helpful as they > >> only record a minor subset of the typical gcc command line options. > >> (Specifically: -O, -g, -D_FORTIFY_SOURCE, -D_GLIBCXX_ASSERTI

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-16 Thread Nick Clifton
Hi Arnaldo, >> Unfortunately the annobin notes will probably not be very helpful as they >> only record a minor subset of the typical gcc command line options. >> (Specifically: -O, -g, -D_FORTIFY_SOURCE, -D_GLIBCXX_ASSERTIONS, >> -fcf-protection, -fpic (and variants), -fshort-enum, >> -fstack-c

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-16 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 16, 2019 at 11:38:30AM +, Nick Clifton escreveu: > Hi Guys, > > > >> Humm, it would be nice for perf annotate to show those options when one > >> navigates the annotation, > > Usually the command line options can also be found in the debug info for > the executable. Assuming it

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-16 Thread Nick Clifton
Hi Guys, >> Humm, it would be nice for perf annotate to show those options when one >> navigates the annotation, Usually the command line options can also be found in the debug info for the executable. Assuming it has not been stripped, of course. One of the advantages of the annobin strategy

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-15 Thread Namhyung Kim
Hi, On Tue, Jan 15, 2019 at 01:35:40PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 15, 2019 at 04:13:16PM +, Nick Clifton escreveu: > > Hi Jiri, > > > > > When perf is built with annobin plugin (RHEL8 build) extra symbols > > > are added to its binary: > > > > A bit of background

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-15 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 15, 2019 at 04:13:16PM +, Nick Clifton escreveu: > Hi Jiri, > > > When perf is built with annobin plugin (RHEL8 build) extra symbols > > are added to its binary: > > A bit of background for those wondering why annobin is creating > these symbols: Annobin is a plugin for gcc t

Re: [RFC] perf tools: Filter out hidden symbols from labels

2019-01-15 Thread Nick Clifton
Hi Jiri, > When perf is built with annobin plugin (RHEL8 build) extra symbols > are added to its binary: A bit of background for those wondering why annobin is creating these symbols: Annobin is a plugin for gcc that records data about how object file were built. It is specifically desig