Re: [RFC] [patch 4/6 -rt] powerpc 2.6.20-rt8: fix a runtime warnings for xmon

2007-03-07 Thread Arnd Bergmann
On Wednesday 07 March 2007, Ingo Molnar wrote: > i'm not an xmon expert, but maybe it might make more sense to first > disable preemption, then interrupts - otherwise you could be preempted > right after having disabled these interrupts (and be scheduled to > another CPU, etc.). What is the diff

Re: [RFC] [patch 4/6 -rt] powerpc 2.6.20-rt8: fix a runtime warnings for xmon

2007-03-07 Thread Tsutomu OWA
At Wed, 07 Mar 2007 11:10:59 +0100, Benjamin Herrenschmidt wrote: > > On Wed, 2007-03-07 at 10:16 +0100, Ingo Molnar wrote: > > * Tsutomu OWA <[EMAIL PROTECTED]> wrote: > > > > > @@ -342,6 +342,7 @@ static int xmon_core(struct pt_regs *reg > > > > > > msr = mfmsr(); > > > mtmsr(msr & ~MSR_

Re: [RFC] [patch 4/6 -rt] powerpc 2.6.20-rt8: fix a runtime warnings for xmon

2007-03-07 Thread Benjamin Herrenschmidt
On Wed, 2007-03-07 at 10:16 +0100, Ingo Molnar wrote: > * Tsutomu OWA <[EMAIL PROTECTED]> wrote: > > > @@ -342,6 +342,7 @@ static int xmon_core(struct pt_regs *reg > > > > msr = mfmsr(); > > mtmsr(msr & ~MSR_EE); /* disable interrupts */ > > + preempt_disable(); > > i'm not an xmon

Re: [RFC] [patch 4/6 -rt] powerpc 2.6.20-rt8: fix a runtime warnings for xmon

2007-03-07 Thread Ingo Molnar
* Tsutomu OWA <[EMAIL PROTECTED]> wrote: > @@ -342,6 +342,7 @@ static int xmon_core(struct pt_regs *reg > > msr = mfmsr(); > mtmsr(msr & ~MSR_EE); /* disable interrupts */ > + preempt_disable(); i'm not an xmon expert, but maybe it might make more sense to first disable pree