Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-20 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 11:00:34AM -0700, Andrew Morton wrote: > On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > > On Thu, 18 Oct 2007 11:12:41 +0200 > > > Samuel Ortiz <[EMAIL PROTECTED]> wrote: >

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread Thomas Gleixner
On Fri, 19 Oct 2007, Andrew Morton wrote: > On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > > On Thu, 18 Oct 2007 11:12:41 +0200 > > > Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > > > > > +#inclu

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread Andrew Morton
On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz <[EMAIL PROTECTED]> wrote: > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > On Thu, 18 Oct 2007 11:12:41 +0200 > > Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > > > +#include > > > +#include > > > +#include > > > > Please see t

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread pHilipp Zabel
On 10/19/07, Samuel Ortiz <[EMAIL PROTECTED]> wrote: > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > On Thu, 18 Oct 2007 11:12:41 +0200 > > Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > You're not a big fan of checkpatch, I see. > Well, now I am :-) > I fixed all the errors, ther

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread Samuel Ortiz
On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > On Thu, 18 Oct 2007 11:12:41 +0200 > Samuel Ortiz <[EMAIL PROTECTED]> wrote: > You're not a big fan of checkpatch, I see. Well, now I am :-) I fixed all the errors, there are only a couple lines being more than 80 characters left. >

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 12:15:47AM +0200, Thomas Gleixner wrote: > On Thu, 18 Oct 2007, Andrew Morton wrote: > > > + > > > +#include > > > +#include > > > +#include > > > > Please see the large comment at the top of linux/irq.h. I believe this > > driver will fial to compile on at least arm. >

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Thomas Gleixner
On Thu, 18 Oct 2007, Andrew Morton wrote: > > + > > +#include > > +#include > > +#include > > Please see the large comment at the top of linux/irq.h. I believe this > driver will fial to compile on at least arm. > > We really should fix this. drivers are fine with: #include If they need li

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Andrew Morton
On Thu, 18 Oct 2007 11:12:41 +0200 Samuel Ortiz <[EMAIL PROTECTED]> wrote: > Hi, > > This is a patch for the Compaq ASIC3 multi function chip, found in many PDAs > (iPAQs, HTCs...). > It is a simplified version of Paul Sokolovsky's first proposal [1]. With this > code, it is basically a GPIO and