Re: [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs

2019-05-08 Thread Linus Torvalds
On Wed, May 8, 2019 at 1:12 AM Peter Zijlstra wrote: > > Hated-by: Linus Torvalds I can live with this cleaned-up version. I'm still not loving it, but at least it now tries very hard to simplify other code. You can remote the hated-by. Linus

Re: [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs

2019-05-08 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Wed, May 08, 2019 at 09:49:05AM +0200, Peter Zijlstra wrote: > > Currently pt_regs on x86_32 has an oddity in that kernel regs > > (!user_mode(regs)) are short two entries (esp/ss). This means that any > > code trying to use them (typically: regs->sp) needs to jump

Re: [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs

2019-05-08 Thread Josh Poimboeuf
On Wed, May 08, 2019 at 09:49:05AM +0200, Peter Zijlstra wrote: > Currently pt_regs on x86_32 has an oddity in that kernel regs > (!user_mode(regs)) are short two entries (esp/ss). This means that any > code trying to use them (typically: regs->sp) needs to jump through > some unfortunate hoops. >