Re: [RFC][PATCH 12/12] perf: Collapse and fix event_function_call() users

2016-02-18 Thread Peter Zijlstra
On Thu, Feb 18, 2016 at 08:46:20AM +0100, Peter Zijlstra wrote: > On Wed, Feb 17, 2016 at 05:38:43PM -0500, Sasha Levin wrote: > > Hey Peter, > > > > I seem to be hitting a warning added by this patch: > > > > [ 258.890172] WARNING: CPU: 5 PID: 14801 at kernel/events/core.c:226 > > event_functi

Re: [RFC][PATCH 12/12] perf: Collapse and fix event_function_call() users

2016-02-17 Thread Peter Zijlstra
On Wed, Feb 17, 2016 at 05:38:43PM -0500, Sasha Levin wrote: > Hey Peter, > > I seem to be hitting a warning added by this patch: > > [ 258.890172] WARNING: CPU: 5 PID: 14801 at kernel/events/core.c:226 > event_function+0x3a7/0x550() Yes, I've been chasing this one for the past few days. I ha

Re: [RFC][PATCH 12/12] perf: Collapse and fix event_function_call() users

2016-02-17 Thread Sasha Levin
On 01/11/2016 11:25 AM, Peter Zijlstra wrote: > There is one common bug left in all the event_function_call() users, > between loading ctx->task and getting to the remote_function(), > ctx->task can already have been changed. > > Therefore we need to double check and retry if ctx->task != current.