Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-10 Thread Petr Mladek
On Mon 2014-11-10 12:37:47, Steven Rostedt wrote: > On Mon, 10 Nov 2014 14:53:30 +0100 > Petr Mladek wrote: > > > > +/* > > > + * How much buffer is left on the seq_buf? > > > + */ > > > +static inline unsigned int > > > +seq_buf_buffer_left(struct seq_buf *s) > > > +{ > > > + return (s->size - 1

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-10 Thread Steven Rostedt
On Mon, 10 Nov 2014 14:53:30 +0100 Petr Mladek wrote: > > +/* > > + * How much buffer is left on the seq_buf? > > + */ > > +static inline unsigned int > > +seq_buf_buffer_left(struct seq_buf *s) > > +{ > > + return (s->size - 1) - s->len; > > This should be > > if (seq_buf_has_overflowe

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-10 Thread Petr Mladek
On Fri 2014-11-07 13:30:17, Steven Rostedt wrote: > > I'm not going to waist bandwidth reposting the entire series. Here's a > new version of this patch. I'm getting ready to pull it into my next > queue. > > -- Steve > > From 11674c8df0580a03a2517e3a8e4705c47c663564 Mon Sep 17 00:00:00 2001 > F

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-07 Thread Steven Rostedt
On Fri, 07 Nov 2014 10:59:27 -0800 Joe Perches wrote: > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > > be limited to page size. This will allow other usages of seq_buf > > instead of a hard set PAGE_SIZE one that trace_seq has. > > > > Link: http://lkml.kernel.org/r/2

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-07 Thread Joe Perches
On Fri, 2014-11-07 at 13:30 -0500, Steven Rostedt wrote: > I'm not going to waist bandwidth reposting the entire series. Here's a > new version of this patch. I'm getting ready to pull it into my next > queue. All this seems sensible enough though I think it'd be nicer if all the touch-ups were co

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-07 Thread Steven Rostedt
I'm not going to waist bandwidth reposting the entire series. Here's a new version of this patch. I'm getting ready to pull it into my next queue. -- Steve >From 11674c8df0580a03a2517e3a8e4705c47c663564 Mon Sep 17 00:00:00 2001 From: "Steven Rostedt (Red Hat)" Date: Wed, 25 Jun 2014 15:54:42 -0

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-06 Thread Petr Mladek
On Wed 2014-11-05 16:21:46, Steven Rostedt wrote: > On Wed, 5 Nov 2014 16:17:20 -0500 > Steven Rostedt wrote: > > > On Wed, 5 Nov 2014 15:00:07 -0500 > > Steven Rostedt wrote: > > > > > On Wed, 5 Nov 2014 13:41:47 -0500 > > > Steven Rostedt wrote: > > > > > > > > > > > > > > + */ > > > > > >

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-06 Thread Petr Mladek
On Wed 2014-11-05 13:41:47, Steven Rostedt wrote: > On Wed, 5 Nov 2014 15:22:22 +0100 > Petr Mladek wrote: > > > On Tue 2014-11-04 10:52:40, Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > Also I would add an explanation of the overall logic. If I get it > > correctly from the c

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Steven Rostedt
On Wed, 5 Nov 2014 16:17:20 -0500 Steven Rostedt wrote: > On Wed, 5 Nov 2014 15:00:07 -0500 > Steven Rostedt wrote: > > > On Wed, 5 Nov 2014 13:41:47 -0500 > > Steven Rostedt wrote: > > > > > > > > > > > + */ > > > > > +int seq_buf_bitmask(struct seq_buf *s, const unsigned long *maskp, > > >

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Steven Rostedt
On Wed, 5 Nov 2014 15:00:07 -0500 Steven Rostedt wrote: > On Wed, 5 Nov 2014 13:41:47 -0500 > Steven Rostedt wrote: > > > > > > > > + */ > > > > +int seq_buf_bitmask(struct seq_buf *s, const unsigned long *maskp, > > > > + int nmaskbits) > > > > +{ > > > > + unsigned in

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Steven Rostedt
On Wed, 5 Nov 2014 13:41:47 -0500 Steven Rostedt wrote: > > > > > + */ > > > +int seq_buf_bitmask(struct seq_buf *s, const unsigned long *maskp, > > > + int nmaskbits) > > > +{ > > > + unsigned int len = SEQ_BUF_LEFT(s); > > > > > > + int ret; > > > + > > > + WARN_ON(s->size == 0); >

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Steven Rostedt
On Wed, 5 Nov 2014 15:26:20 +0100 Petr Mladek wrote: > > index ..97872154d51c > > --- /dev/null > > +++ b/include/linux/seq_buf.h > > @@ -0,0 +1,72 @@ > > +#ifndef _LINUX_SEQ_BUF_H > > +#define _LINUX_SEQ_BUF_H > > + > > +#include > > + > > +#include > > One more small thing. We d

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Steven Rostedt
On Wed, 5 Nov 2014 15:22:22 +0100 Petr Mladek wrote: > On Tue 2014-11-04 10:52:40, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > > be limited to page size. This will allow other usages of seq_buf > > inst

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Petr Mladek
On Tue 2014-11-04 10:52:40, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > be limited to page size. This will allow other usages of seq_buf > instead of a hard set PAGE_SIZE one that trace_seq has. > > Signed-off

Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq

2014-11-05 Thread Petr Mladek
On Tue 2014-11-04 10:52:40, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > be limited to page size. This will allow other usages of seq_buf > instead of a hard set PAGE_SIZE one that trace_seq has. > > Signed-off