Re: [RFC][PATCH] bug: Add _ONCE logic to report_bug()

2017-02-25 Thread Peter Zijlstra
On Sat, Feb 25, 2017 at 10:18:23AM +0100, Ingo Molnar wrote: > > Sadly this only works for WARN_ON_ONCE(), since the others have > > printk() statements prior to triggering the trap. > > Which one is problematic to convert, WARN_ONCE()? Yes, WARN_ONCE(), all the ones that have printf fmt crud in

Re: [RFC][PATCH] bug: Add _ONCE logic to report_bug()

2017-02-25 Thread Ingo Molnar
* Peter Zijlstra wrote: > > Josh suggested moving the _ONCE logic inside the trap handler, using a > bit in the bug_entry::flags field, avoiding the need for the extra > variable. This looks interesting, as the _ONCE() methods of warning are far more user-friendly than WARN() spam. > Sadly t