Re: [RFC][PATCH] NTP shiftR cleanup

2005-09-09 Thread Roman Zippel
Hi, On Fri, 9 Sep 2005, john stultz wrote: > +/* Required to safely shift negative values */ > +#define shiftR(x, s) ({ __typeof__(x) __x = x;\ > + __typeof__(s) __s = s; \ > + (__x < 0) ? (-((-__x) >> (__s))) : ((__x) >> (__s));}) > + Some parenthesis are missing and som

Re: [RFC][PATCH] NTP shiftR cleanup

2005-09-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 09 Sep 2005 18:03:37 -0700), john stultz <[EMAIL PROTECTED]> says: > diff --git a/kernel/time.c b/kernel/time.c > --- a/kernel/time.c > +++ b/kernel/time.c > @@ -338,30 +338,20 @@ int do_adjtimex(struct timex *txc) > if (mtemp >= MINSE