Re: [RFC][PATCH] Mount problem with the GFS2 code

2006-11-30 Thread Steven Whitehouse
Hi, On Thu, 2006-11-30 at 01:12 -0800, Andrew Morton wrote: > On Thu, 30 Nov 2006 09:05:38 + > Steven Whitehouse <[EMAIL PROTECTED]> wrote: > > > Was there another > > reason for not using the bio routines? > > Just that it's a layering violation. > > Could I commend to you the use of code

Re: [RFC][PATCH] Mount problem with the GFS2 code

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 09:05:38 + Steven Whitehouse <[EMAIL PROTECTED]> wrote: > Was there another > reason for not using the bio routines? Just that it's a layering violation. Could I commend to you the use of code comments for this sort of thing? - To unsubscribe from this list: send the line

Re: [RFC][PATCH] Mount problem with the GFS2 code

2006-11-30 Thread Steven Whitehouse
Hi, On Thu, 2006-11-30 at 00:29 -0800, Andrew Morton wrote: > On Thu, 30 Nov 2006 15:04:55 +0530 > Srinivasa Ds <[EMAIL PROTECTED]> wrote: > > > == > > On debugging further we found that problem is while reading the super >

Re: [RFC][PATCH] Mount problem with the GFS2 code

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 15:04:55 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > == > On debugging further we found that problem is while reading the super > block(gfs2_read_super) and comparing the magic number in it. > When I