Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-05-10 Thread Peter Zijlstra
On Mon, Mar 04, 2013 at 03:21:05PM +1100, Michael Ellerman wrote: > Make it explicit that the format attributes may define overlapping bit > ranges. Unfortunately this was left unspecified originally, and all the > examples show non-overlapping ranges. I don't believe this is an ABI > change, as we

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-05-06 Thread Arnaldo Carvalho de Melo
Em Mon, May 06, 2013 at 11:08:30AM +1000, Michael Ellerman escreveu: > On Mon, Apr 08, 2013 at 05:24:22PM +1000, Michael Ellerman wrote: > > On Mon, Mar 04, 2013 at 03:21:05PM +1100, Michael Ellerman wrote: > > > Make it explicit that the format attributes may define overlapping bit > > > ranges. U

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-05-06 Thread Jiri Olsa
On Mon, May 06, 2013 at 05:20:08AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, May 06, 2013 at 11:08:30AM +1000, Michael Ellerman escreveu: > > On Mon, Apr 08, 2013 at 05:24:22PM +1000, Michael Ellerman wrote: > > > On Mon, Mar 04, 2013 at 03:21:05PM +1100, Michael Ellerman wrote: > > > > Make

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-05-05 Thread Michael Ellerman
On Mon, Apr 08, 2013 at 05:24:22PM +1000, Michael Ellerman wrote: > On Mon, Mar 04, 2013 at 03:21:05PM +1100, Michael Ellerman wrote: > > Make it explicit that the format attributes may define overlapping bit > > ranges. Unfortunately this was left unspecified originally, and all the > > examples s

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-04-08 Thread Jiri Olsa
On Mon, Apr 08, 2013 at 09:57:50PM +1000, Michael Ellerman wrote: SNIP > > > > ISTR discussing this with Jiri at some point.. I think we ended up with > > being fine with overlapping ranges but having perf issue a warning (not > > an error) when attributes of a single event have overlap. > > OK

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-04-08 Thread Michael Ellerman
On Mon, Apr 08, 2013 at 11:05:15AM +0200, Peter Zijlstra wrote: > On Mon, 2013-03-04 at 15:21 +1100, Michael Ellerman wrote: > > Make it explicit that the format attributes may define overlapping bit > > ranges. Unfortunately this was left unspecified originally, and all the > > examples show non-o

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-04-08 Thread Peter Zijlstra
On Mon, 2013-03-04 at 15:21 +1100, Michael Ellerman wrote: > Make it explicit that the format attributes may define overlapping bit > ranges. Unfortunately this was left unspecified originally, and all the > examples show non-overlapping ranges. I don't believe this is an ABI > change, as we are de

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-04-08 Thread Michael Ellerman
On Mon, Mar 04, 2013 at 03:21:05PM +1100, Michael Ellerman wrote: > Make it explicit that the format attributes may define overlapping bit > ranges. Unfortunately this was left unspecified originally, and all the > examples show non-overlapping ranges. I don't believe this is an ABI > change, as we