Re: [RFC/PATCH] dma: dma_{un}map_{single|sg}_attrs() interface

Thanks for the review. An updated version of the patch follows. On Tue, Jan 22, 2008 at 08:59:50PM -0800, Roland Dreier wrote: > > ... > > +static inline int dma_set_attr(struct dma_attrs *attrs, unsigned attr) { > > maybe this would be cleaner if you named the DMA_ATTR enum and used > that

Re: [RFC/PATCH] dma: dma_{un}map_{single|sg}_attrs() interface

> --- a/include/linux/dma-attrs.h > +++ b/include/linux/dma-attrs.h > @@ -0,0 +1,33 @@ > +#ifndef _DMA_ATTR_H > +#define _DMA_ATTR_H > + > +#include > + > +enum { > +DMA_ATTR_INVALID, > +DMA_ATTR_BARRIER, > +DMA_ATTR_FOO, > +DMA_ATTR_GOO, > +DMA_ATTR_MAX, > +};