Re: [RFC,v2,3/8] video: tegra: host: Add channel and client support

2012-11-29 Thread Mark Zhang
On 11/29/2012 06:46 PM, Terje Bergström wrote: > On 29.11.2012 12:01, Mark Zhang wrote: >> >> Just for curious, why "pb->mapped + 1K" is the end of a 4K pushbuffer? > > pb->mapped is u32 *, so compiler will take care of multiplying by > sizeof(u32). > Ah, yes. Sorry, I must be insane at that tim

Re: [RFC,v2,3/8] video: tegra: host: Add channel and client support

2012-11-29 Thread Terje Bergström
On 29.11.2012 12:01, Mark Zhang wrote: >> +fail: >> +/* Add clean-up */ > > Yes, add "nvhost_module_deinit" here? Sounds good. >> +int nvhost_client_device_suspend(struct platform_device *dev) >> +{ >> +int ret = 0; >> +struct nvhost_device_data *pdata = platform_get_drvdata(dev); >>

Re: [RFC,v2,3/8] video: tegra: host: Add channel and client support

2012-11-29 Thread Mark Zhang
On 11/26/2012 09:19 PM, Terje Bergström wrote: > Add support for host1x client modules, and host1x channels to submit > work to the clients. The work is submitted in dmabuf buffers, so add > support for dmabuf memory management, too. [...] > diff --git a/drivers/video/tegra/host/bus_client.c > b/