Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-28 Thread Manivannan Sadhasivam
On Sun, Feb 28, 2021 at 03:12:42PM +0100, Aleksander Morgado wrote: > Hey Manivannan, Jakub & all, > > > > > So please let us know the path forward on this series. We are open to > > any suggestions but you haven't provided one till now. > > > > I just found out that Sierra Wireless also provides

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-28 Thread Aleksander Morgado
Hey Manivannan, Jakub & all, > > So please let us know the path forward on this series. We are open to > any suggestions but you haven't provided one till now. > I just found out that Sierra Wireless also provides their own version of mhi-net and mhi-uci in precompiled binaries for several Ubuntu

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-11 Thread Aleksander Morgado
> What bothers me is maintaining shim drivers which just shuttle opaque > messages between user space and firmware. One of which definitely is, > and the other may well be, proprietary. This is an open source project, > users are supposed to be able to meaningfully change the behavior of > the syst

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Bjorn Andersson
On Wed 10 Feb 12:41 CST 2021, Jakub Kicinski wrote: > On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > > This may be a stupid suggestion, but

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Jeffrey Hugo
On 2/10/2021 11:41 AM, Jakub Kicinski wrote: On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: This may be a stupid suggestion, but would the integration lo

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > This may be a stupid suggestion, but would the integration look less a > > > backdoor if it would

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Manivannan Sadhasivam
On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > This may be a stupid suggestion, but would the integration look less a > > backdoor if it would have been named "mhi_wwan" and it exposed already > > all the AT+DIAG+QMI

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Aleksander Morgado
Hey, > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > This may be a stupid suggestion, but would the integration look less a > > backdoor if it would have been named "mhi_wwan" and it exposed already > > all the AT+DIAG+QMI+MBIM+NMEA possible channels as chardevs, not just > > QMI

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > This may be a stupid suggestion, but would the integration look less a > backdoor if it would have been named "mhi_wwan" and it exposed already > all the AT+DIAG+QMI+MBIM+NMEA possible channels as chardevs, not just > QMI? What's DIAG?

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Aleksander Morgado
Hey Jakub On Wed, Feb 3, 2021 at 7:41 PM Jakub Kicinski wrote: > > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI cha

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Bjorn Andersson
On Wed 03 Feb 12:40 CST 2021, Jakub Kicinski wrote: > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI channel so I'd

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Manivannan Sadhasivam
On Wed, Feb 03, 2021 at 10:40:28AM -0800, Jakub Kicinski wrote: > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI chan

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > The current patchset only supports QMI channel so I'd request you to > > > review the chardev node created for it.

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Bjorn Andersson
On Wed 03 Feb 12:05 CST 2021, Jakub Kicinski wrote: > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > > >> provided an explanation above and in the previous iteration [1]. > > > > > >Let's be clear wha

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Loic Poulain
Hi Jakub, On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > > >> provided an explanation above and in the previous iteration [1]. > > > > > >Let's be

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Jakub Kicinski
On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > >> provided an explanation above and in the previous iteration [1]. > > > >Let's be clear what the review would be for. Yet another QMI chardev > >or the "

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-02 Thread Manivannan Sadhasivam
Hi Jakub, On 3 February 2021 9:40:08 AM IST, Jakub Kicinski wrote: >On Tue, 2 Feb 2021 09:52:08 +0530 Manivannan Sadhasivam wrote: >> > > I don't see the connection here, sorry. >> > >> > For instance USB_NET_CDC_MBIM driver creates the /dev/cdc-wdmX >chardev node for >> > configuring the modem

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-02 Thread Jakub Kicinski
On Tue, 2 Feb 2021 09:52:08 +0530 Manivannan Sadhasivam wrote: > > > I don't see the connection here, sorry. > > > > For instance USB_NET_CDC_MBIM driver creates the /dev/cdc-wdmX chardev node > > for > > configuring the modems which supports MBIM protocol over USB. Like that, > > this > > drive

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Manivannan Sadhasivam
+ Jakub, Dave On Mon, Feb 01, 2021 at 05:43:22PM +0530, Manivannan Sadhasivam wrote: > On Mon, Feb 01, 2021 at 12:15:51PM +0100, Greg KH wrote: > > On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote: > > > Hi Greg, > > > > > > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH w

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Manivannan Sadhasivam
On Mon, Feb 01, 2021 at 12:15:51PM +0100, Greg KH wrote: > On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote: > > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > > > Hi Gr

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote: > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > > Hi Greg, > > > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kum

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Manivannan Sadhasivam
Hi Greg, On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote: > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI driver enables >

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-27 Thread Bjorn Andersson
On Wed 27 Jan 09:15 CST 2021, Greg KH wrote: > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI driver enables > > > userspace > > > c

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-27 Thread Greg KH
On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem. UCI dri

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 03:12:50PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-19 Thread Manivannan Sadhasivam
Hi Greg, On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like mode

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-13 Thread Manivannan Sadhasivam
Hi Greg, On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > This patch series adds support for UCI driver. UCI driver enables userspace > clients to communicate to external MHI devices like modem. UCI driver probe > creates standard character device file nodes for userspace clients to