Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-19 Thread Bjorn Andersson
On Wed 18 Oct 09:39 PDT 2017, Srinivas Kandagatla wrote: > Thanks for Review Comments, > > > On 18/10/17 07:15, Bjorn Andersson wrote: > > On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > > > > > + if (!async) { > > > + txn->msg->comp_cb = NULL; > > > + txn->msg->ctx = NU

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-18 Thread Srinivas Kandagatla
Thanks for Review Comments, On 18/10/17 07:15, Bjorn Andersson wrote: On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to represent gain

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-17 Thread Bjorn Andersson
On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to represent interrupt >

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
On Sat, Oct 07, 2017 at 11:24:33AM +0100, Srinivas Kandagatla wrote: > Thanks for the comments. > > On 07/10/17 07:42, Jonathan Neuschäfer wrote: > > Hi, > > > > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > > wrote: > > > From: Sagar Dharia [...] > > > +int slim_xf

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Srinivas Kandagatla
Thanks for the comments. On 07/10/17 07:42, Jonathan Neuschäfer wrote: Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used t

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-06 Thread Jonathan Neuschäfer
Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to repres