Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-02-10 Thread Andy Gross
On Fri, Jan 30, 2015 at 05:17:51PM +0530, Pramod Gurav wrote: > > + > > + achan = to_adm_chan(chan); > Could not understand the use of achan here. unused code? yeah its unnecessary now. will remove. Thanks! > > > + -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-30 Thread Pramod Gurav
Hi Andy, A minor doubt. On Thursday 08 January 2015 08:56 AM, Andy Gross wrote: > Signed-off-by: Andy Gross > --- > drivers/dma/Kconfig| 10 + > drivers/dma/Makefile |1 + > drivers/dma/qcom_adm.c | 899 > > + > + return ret; >

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-09 Thread Andy Gross
On Fri, Jan 09, 2015 at 10:08:20AM +0530, Archit Taneja wrote: > Hi, > > On 01/08/2015 08:56 AM, Andy Gross wrote: > >Signed-off-by: Andy Gross > > > >+static struct dma_async_tx_descriptor *adm_prep_slave_sg(struct dma_chan > >*chan, > >+struct scatterlist *sgl, unsigned int sg_len, > >+

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-08 Thread Archit Taneja
Hi, On 01/08/2015 08:56 AM, Andy Gross wrote: Signed-off-by: Andy Gross +static struct dma_async_tx_descriptor *adm_prep_slave_sg(struct dma_chan *chan, + struct scatterlist *sgl, unsigned int sg_len, + enum dma_transfer_direction direction, unsigned long flags, + void *co

Re: [Patch v2 1/2] dmaengine: Add ADM driver

2015-01-07 Thread Andy Gross
On Wed, Jan 07, 2015 at 09:26:11PM -0600, Andy Gross wrote: I somehow managed to lose my commit message. I'll fix that in the next set. The rest of the patch is fine. > Signed-off-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag