Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Jacopo Mondi
Hi Benoit, On Wed, Oct 02, 2019 at 10:06:15AM -0500, Benoit Parrot wrote: > Jacopo Mondi wrote on Wed [2019-Oct-02 16:32:26 +0200]: > > Hi Benoit, > > > > On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > > > Hi Jacopo, > > > > > > Maybe, I miss spoke when I mentioned a helper I di

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Benoit Parrot
Jacopo Mondi wrote on Wed [2019-Oct-02 16:32:26 +0200]: > Hi Benoit, > > On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > > Hi Jacopo, > > > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > > level generic function. Just a function to help in this cas

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Jacopo Mondi
Hi Benoit, On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > Hi Jacopo, > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > level generic function. Just a function to help in this case :) Yes indeed, the discussion thread I linked here was mostly intere

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Benoit Parrot
Sakari Ailus wrote on Wed [2019-Oct-02 15:35:13 +0300]: > Hi Benoit, > > On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > > Hi Jacopo, > > > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > > level generic function. Just a function to help in this c

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Sakari Ailus
Hi Benoit, On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote: > Hi Jacopo, > > Maybe, I miss spoke when I mentioned a helper I did not intent a framework > level generic function. Just a function to help in this case :) > > That being said, I re-read the thread you mentioned. And as

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Benoit Parrot
Hi Jacopo, Maybe, I miss spoke when I mentioned a helper I did not intent a framework level generic function. Just a function to help in this case :) That being said, I re-read the thread you mentioned. And as Hughes pointed out dynamically generating a "working" link frequency value which can be

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-02 Thread Jacopo Mondi
Hi Benoit, +Hugues If you're considering an helper, this thread might be useful to you: https://patchwork.kernel.org/patch/11019673/ Thanks j On Tue, Oct 01, 2019 at 11:23:41AM -0500, Benoit Parrot wrote: > Hi Sakari, > > Thanks for the review. > > Sakari Ailus wrote on Tue [2019-Oct-01 >

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-01 Thread Benoit Parrot
Hi Sakari, Thanks for the review. Sakari Ailus wrote on Tue [2019-Oct-01 10:57:04 +0300]: > Hi Benoit, > > On Wed, Sep 25, 2019 at 10:22:59AM -0500, Benoit Parrot wrote: > > Add v4l2 controls to report the pixel rates of each mode. This is > > needed by some CSI2 receiver in order to perform p

Re: [Patch 1/3] media: ov5640: add PIXEL_RATE control

2019-10-01 Thread Sakari Ailus
Hi Benoit, On Wed, Sep 25, 2019 at 10:22:59AM -0500, Benoit Parrot wrote: > Add v4l2 controls to report the pixel rates of each mode. This is > needed by some CSI2 receiver in order to perform proper DPHY > configuration. > > Signed-off-by: Benoit Parrot > --- > drivers/media/i2c/ov5640.c | 25