Re: [PATCHv9 02/20] thermal: introduce device tree parser

Hello Wei, On 13-01-2014 22:54, Wei Ni wrote: > On 01/14/2014 05:29 AM, Eduardo Valentin wrote: >> * PGP Signed by an unknown key >> >> Wei, >> >> On 06-01-2014 22:44, Wei Ni wrote: >>> On 01/06/2014 10:54 PM, Eduardo Valentin wrote: > Old Signed by an unknown key On 06-01-2014 09:51

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 01/14/2014 05:29 AM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > Wei, > > On 06-01-2014 22:44, Wei Ni wrote: >> On 01/06/2014 10:54 PM, Eduardo Valentin wrote: Old Signed by an unknown key >>> >>> On 06-01-2014 09:51, Mark Rutland wrote: On Thu, Jan 02, 2014 at 05:50

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Wei, On 06-01-2014 22:44, Wei Ni wrote: > On 01/06/2014 10:54 PM, Eduardo Valentin wrote: >> * PGP Signed by an unknown key >> >> On 06-01-2014 09:51, Mark Rutland wrote: >>> On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: > I think the platform driver may set governor

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 02-01-2014 13:50, Matthew Longnecker wrote: > >> I think the platform driver may set governor for the thermal zone, >> so how about to add a property named as "governor", >> and parse it to tzp->governor_name, >> something like: >> ret = of_property_read_string(child, "governor

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 01/08/2014 11:24 AM, Hu Yaohui wrote: > I am new here. How can I could not mail a new message to this mail list? > TIA I use Thunderbird, it's a pretty good mail client :) > > > On Tue, Jan 7, 2014 at 10:19 PM, Wei Ni > wrote: > > On 01/07/2014 07:17 PM, Eduardo

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 01/07/2014 07:17 PM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > On 06-01-2014 22:48, Wei Ni wrote: >> Hi, Eduardo >> Will you consider my comments :) > > By now Wei, it is better if you start a new thread, by sending a patch > on top of it, as this thread has been already mer

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On Tue, Jan 07, 2014 at 02:44:10AM +, Wei Ni wrote: > On 01/06/2014 10:54 PM, Eduardo Valentin wrote: > > * PGP Signed by an unknown key > > > > On 06-01-2014 09:51, Mark Rutland wrote: > >> On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: > >>> > I think the platform d

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 06-01-2014 22:48, Wei Ni wrote: > Hi, Eduardo > Will you consider my comments :) By now Wei, it is better if you start a new thread, by sending a patch on top of it, as this thread has been already merged by Rui. > > Thanks. > Wei. > > On 12/31/2013 06:17 PM, Wei Ni wrote: >> On 11/13/2013 0

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Hi, Eduardo Will you consider my comments :) Thanks. Wei. On 12/31/2013 06:17 PM, Wei Ni wrote: > On 11/13/2013 03:46 AM, Eduardo Valentin wrote: >> This patch introduces a device tree bindings for >> describing the hardware thermal behavior and limits. >> Also a parser to read and interpret the

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 01/06/2014 10:54 PM, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > On 06-01-2014 09:51, Mark Rutland wrote: >> On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: >>> I think the platform driver may set governor for the thermal zone, so how about to add

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 02-01-2014 13:35, Matthew Longnecker wrote: > Eduardo, Hello Matthew, > > For the most part, this binding is really well thought out. It makes a > lot of sense to me (as someone who has been working with thermal > management in Linux/Android-based mobile devices for a few years). No issues,

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 06-01-2014 09:51, Mark Rutland wrote: > On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: >> >>> I think the platform driver may set governor for the thermal zone, >>> so how about to add a property named as "governor", >>> and parse it to tzp->governor_name, >>> something like

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On Thu, Jan 02, 2014 at 05:50:06PM +, Matthew Longnecker wrote: > > > I think the platform driver may set governor for the thermal zone, > > so how about to add a property named as "governor", > > and parse it to tzp->governor_name, > > something like: > > ret = of_property_re

Re: [PATCHv9 02/20] thermal: introduce device tree parser

I think the platform driver may set governor for the thermal zone, so how about to add a property named as "governor", and parse it to tzp->governor_name, something like: ret = of_property_read_string(child, "governor", &str); if (ret == 0)

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Eduardo, For the most part, this binding is really well thought out. It makes a lot of sense to me (as someone who has been working with thermal management in Linux/Android-based mobile devices for a few years). However, I have one substantive criticism. On 11/12/2013 11:46 AM, Eduardo Valen

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Sorry, please ignore this mail. This is not my regularly mail address. Thanks. Wei. On 01/02/2014 10:55 AM, Wei Ni wrote: > On 11/13/2013 03:46 AM, Eduardo Valentin wrote: >> >> + >> +/** >> + * of_parse_thermal_zones - parse device tree thermal data >> + * >> + * Initialization function tha

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 11/13/2013 03:46 AM, Eduardo Valentin wrote: > ... > + > +/** > + * of_parse_thermal_zones - parse device tree thermal data > + * > + * Initialization function that can be called by machine initialization > + * code to parse thermal data and populate the thermal framework > + * with hardware the

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 11/13/2013 03:46 AM, Eduardo Valentin wrote: > > + > +/** > + * of_parse_thermal_zones - parse device tree thermal data > + * > + * Initialization function that can be called by machine initialization > + * code to parse thermal data and populate the thermal framework > + * with hardware th

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 11/13/2013 03:46 AM, Eduardo Valentin wrote: > This patch introduces a device tree bindings for > describing the hardware thermal behavior and limits. > Also a parser to read and interpret the data and feed > it in the thermal framework is presented. > > This patch introduces a thermal data pars

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 25-11-2013 11:37, Mark Rutland wrote: > On Tue, Nov 12, 2013 at 07:46:04PM +, Eduardo Valentin wrote: >> This patch introduces a device tree bindings for >> describing the hardware thermal behavior and limits. >> Also a parser to read and interpret the data and feed >> it in the thermal fram

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 25-11-2013 11:31, Mark Rutland wrote: > I think if these are needed the set of types can be extended, no? > As long as we have a real board with real use cases to be covered, yes, why not. -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 25-11-2013 11:31, Mark Rutland wrote: > Any cooling device has a range of cooling states (i.e. different levels > of heat dissipation). For example a fan's cooling states correspond to > the different fan speeds possible. Cooling states are referred to by > single unsigned integers, where larger

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On Tue, Nov 12, 2013 at 07:46:04PM +, Eduardo Valentin wrote: > This patch introduces a device tree bindings for > describing the hardware thermal behavior and limits. > Also a parser to read and interpret the data and feed > it in the thermal framework is presented. > > This patch introduces

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 25-11-2013 11:14, Mark Rutland wrote: > [...] > >>> +* Trip points >>> + >>> +The trip node is a node to describe a point in the temperature domain >>> +in which the system takes an action. This node describes just the >>> point, >>> +not the action. >>> + >>> +

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On Fri, Nov 22, 2013 at 12:33:34PM +, Eduardo Valentin wrote: > > Hello Tomasz, > > On 21-11-2013 12:32, Tomasz Figa wrote: > > On Thursday 21 of November 2013 11:48:08 Eduardo Valentin wrote: > >> On 21-11-2013 10:57, Tomasz Figa wrote: > >>> On Friday 15 of November 2013 09:19:02 Eduardo Va

Re: [PATCHv9 02/20] thermal: introduce device tree parser

[...] > > +* Trip points > > + > > +The trip node is a node to describe a point in the temperature domain > > +in which the system takes an action. This node describes just the > > point, > > +not the action. > > + > > +Required properties: > > +- temp

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Hello Tomasz, On 21-11-2013 12:32, Tomasz Figa wrote: > On Thursday 21 of November 2013 11:48:08 Eduardo Valentin wrote: >> On 21-11-2013 10:57, Tomasz Figa wrote: >>> On Friday 15 of November 2013 09:19:02 Eduardo Valentin wrote: Hello Tomasz, On 14-11-2013 09:40, Tomasz Figa wrot

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Hello Tomasz, On 14-11-2013 09:40, Tomasz Figa wrote: > On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: >> On 13-11-2013 12:57, Tomasz Figa wrote: >>> Hi Eduardo, >>> >> >> Hello Tomaz >> >>> On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: This patch introduce

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On Thursday 14 of November 2013 07:31:04 Eduardo Valentin wrote: > On 13-11-2013 12:57, Tomasz Figa wrote: > > Hi Eduardo, > > > > Hello Tomaz > > > On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: > >> This patch introduces a device tree bindings for > >> describing the hardware

Re: [PATCHv9 02/20] thermal: introduce device tree parser

On 13-11-2013 12:57, Tomasz Figa wrote: > Hi Eduardo, > Hello Tomaz > On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: >> This patch introduces a device tree bindings for >> describing the hardware thermal behavior and limits. >> Also a parser to read and interpret the data and fe

Re: [PATCHv9 02/20] thermal: introduce device tree parser

Hi Eduardo, On Tuesday 12 of November 2013 15:46:04 Eduardo Valentin wrote: > This patch introduces a device tree bindings for > describing the hardware thermal behavior and limits. > Also a parser to read and interpret the data and feed > it in the thermal framework is presented. [snip] > diff --