Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-27 Thread Andrea Arcangeli
Hello Andres, On Tue, Apr 19, 2016 at 10:07:29AM -0700, Andres Lagar-Cavilla wrote: > Andrea, we provide the, ahem, adjustments to > transparent_hugepage_adjust. Rest assured we aggressively use mmu > notifiers with no further changes required. Did you notice I just fixed a THP related bug in the

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-26 Thread Wincy Van
On Mon, Apr 25, 2016 at 9:30 PM, Andres Lagar-Cavilla wrote: >> >> We are using kvm + tmpfs to do qemu live upgrading, how does google >> use this memory model ? >> I think our pupose to use tmpfs may be the same. > > Nothing our of the ordinary. Guest memory is an mmap of a tmpfs fd. > Huge tmpfs

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-25 Thread Andres Lagar-Cavilla
On Sat, Apr 23, 2016 at 10:46 PM, Wincy Van wrote: > On Wed, Apr 20, 2016 at 1:07 AM, Andres Lagar-Cavilla > wrote: >> Andrea, we provide the, ahem, adjustments to >> transparent_hugepage_adjust. Rest assured we aggressively use mmu >> notifiers with no further changes required. >> >> As in: zero

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-23 Thread Wincy Van
On Wed, Apr 20, 2016 at 1:07 AM, Andres Lagar-Cavilla wrote: > Andrea, we provide the, ahem, adjustments to > transparent_hugepage_adjust. Rest assured we aggressively use mmu > notifiers with no further changes required. > > As in: zero changes have been required in the lifetime (years) of > kvm+

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-20 Thread Hugh Dickins
On Mon, 18 Apr 2016, Shi, Yang wrote: > Hi Kirill, > > Finally, I got some time to look into and try yours and Hugh's patches, got Thank you. > two problems. > > 1. A quick boot up test on my ARM64 machine with your v7 tree shows some > unexpected error: > > systemd-journald[285]: Failed to s

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Shi, Yang
On 4/19/2016 9:50 AM, Andrea Arcangeli wrote: Hello, On Mon, Apr 18, 2016 at 03:55:44PM -0700, Shi, Yang wrote: Hi Kirill, Finally, I got some time to look into and try yours and Hugh's patches, got two problems. One thing that come to mind to test is this: qemu with -machine accel=kvm -mem-

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Andres Lagar-Cavilla
Andrea, we provide the, ahem, adjustments to transparent_hugepage_adjust. Rest assured we aggressively use mmu notifiers with no further changes required. As in: zero changes have been required in the lifetime (years) of kvm+huge tmpfs at Google, other than mod'ing transparent_hugepage_adjust. As

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Andrea Arcangeli
Hello, On Mon, Apr 18, 2016 at 03:55:44PM -0700, Shi, Yang wrote: > Hi Kirill, > > Finally, I got some time to look into and try yours and Hugh's patches, > got two problems. One thing that come to mind to test is this: qemu with -machine accel=kvm -mem-path=/dev/shm/,share=on . The THP Compou

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Shi, Yang
On 4/19/2016 7:33 AM, Jerome Marchand wrote: On 04/19/2016 12:55 AM, Shi, Yang wrote: 2. I ran my THP test (generated a program with 4MB text section) on both x86-64 and ARM64 with yours and Hugh's patches (linux-next tree), I got the program execution time reduced by ~12% on x86-64, it looks ve

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Jerome Marchand
On 04/19/2016 12:55 AM, Shi, Yang wrote: > 2. I ran my THP test (generated a program with 4MB text section) on both > x86-64 and ARM64 with yours and Hugh's patches (linux-next tree), I got > the program execution time reduced by ~12% on x86-64, it looks very > impressive. > > But, on ARM64, there

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-18 Thread Shi, Yang
Hi Kirill, Finally, I got some time to look into and try yours and Hugh's patches, got two problems. 1. A quick boot up test on my ARM64 machine with your v7 tree shows some unexpected error: systemd-journald[285]: Failed to save stream data /run/systemd/journal/streams/8:16863: No space l