Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2016-01-04 Thread Keith Busch
Hi, thanks for the feedback. I've a few follow up questions. On Sun, Jan 03, 2016 at 03:11:24PM +0100, Martin Mares wrote: > This is definitely not enough. Try grepping the source for "domain" :-) > > At least the following places need updating, too: > > o struct pci_filter and operations on i

Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2016-01-03 Thread Martin Mares
Hello! > PCI-e segments will continue to use the lower 16 bits as required by > ACPI. Special domains may use the full 32-bits. > > Signed-off-by: Keith Busch > --- > lib/filter.c |2 +- > lib/pci.h|2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/filte

Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2015-12-17 Thread Bjorn Helgaas
On Thu, Dec 17, 2015 at 05:34:46PM +, Keith Busch wrote: > On Thu, Dec 17, 2015 at 11:15:45AM -0600, Bjorn Helgaas wrote: > > > @@ -45,7 +45,7 @@ pci_filter_parse_slot_v33(struct pci_filter *f, char > > > *str) > > > if (str[0] && strcmp(str, "*")) > > > { > > > long int x =

Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2015-12-17 Thread Keith Busch
On Thu, Dec 17, 2015 at 11:15:45AM -0600, Bjorn Helgaas wrote: > > @@ -45,7 +45,7 @@ pci_filter_parse_slot_v33(struct pci_filter *f, char *str) > > if (str[0] && strcmp(str, "*")) > > { > > long int x = strtol(str, &e, 16); > > - if ((e && *e) || (x < 0 || x > 0x

Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2015-12-17 Thread Bjorn Helgaas
Hi Keith, On Mon, Dec 07, 2015 at 02:32:29PM -0700, Keith Busch wrote: > PCI-e segments will continue to use the lower 16 bits as required by > ACPI. Special domains may use the full 32-bits. > > Signed-off-by: Keith Busch > --- > lib/filter.c |2 +- > lib/pci.h|2 +- > 2 files chan

Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

2015-12-12 Thread Andy Shevchenko
On Mon, Dec 7, 2015 at 11:32 PM, Keith Busch wrote: > PCI-e segments will continue to use the lower 16 bits as required by > ACPI. Special domains may use the full 32-bits. > > Signed-off-by: Keith Busch > --- > lib/filter.c |2 +- > lib/pci.h|2 +- > 2 files changed, 2 insertions(+)