Re: [PATCHv5 10/19] x86/mm: Implement page_keyid() using page_ext

2018-07-23 Thread Alison Schofield
On Mon, Jul 23, 2018 at 12:45:17PM +0300, Kirill A. Shutemov wrote: > On Wed, Jul 18, 2018 at 04:38:02PM -0700, Dave Hansen wrote: > > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > > Store KeyID in bits 31:16 of extended page flags. These bits are unused. > > > > I'd love a two sentence re

Re: [PATCHv5 10/19] x86/mm: Implement page_keyid() using page_ext

2018-07-23 Thread Kirill A. Shutemov
On Wed, Jul 18, 2018 at 04:38:02PM -0700, Dave Hansen wrote: > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > Store KeyID in bits 31:16 of extended page flags. These bits are unused. > > I'd love a two sentence remind of what page_ext is and why you chose to > use it. Yes, you need this.

Re: [PATCHv5 10/19] x86/mm: Implement page_keyid() using page_ext

2018-07-18 Thread Dave Hansen
On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > Store KeyID in bits 31:16 of extended page flags. These bits are unused. I'd love a two sentence remind of what page_ext is and why you chose to use it. Yes, you need this. No, not everybody that you want to review this patch set knows what it