Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-11 Thread Greg KH
On Thu, Oct 11, 2012 at 11:37:20AM +0200, Arun MURTHY wrote: > > On Tue, Oct 09, 2012 at 07:37:02AM +0200, Arun MURTHY wrote: > > > Any further comments? > > > > I was waiting for you to address all of the previous ones with a new set of > > patches before burdening you with anything new :) > > T

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-11 Thread Arun MURTHY
> On Tue, Oct 09, 2012 at 07:37:02AM +0200, Arun MURTHY wrote: > > Any further comments? > > I was waiting for you to address all of the previous ones with a new set of > patches before burdening you with anything new :) There are not any changes in the code, this review was more like just explai

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-09 Thread Greg KH
On Tue, Oct 09, 2012 at 07:37:02AM +0200, Arun MURTHY wrote: > Any further comments? I was waiting for you to address all of the previous ones with a new set of patches before burdening you with anything new :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-08 Thread Arun MURTHY
> > On Wed, Oct 03, 2012 at 05:54:08AM +0200, Arun MURTHY wrote: > > > > On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > > > > > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > > > > > > +#include > > > > > > > +#include > > > > > > > +#include > > > > > > > +#i

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-03 Thread Arun MURTHY
> On Wed, Oct 03, 2012 at 05:54:08AM +0200, Arun MURTHY wrote: > > > On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > > > > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > >

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 05:54:08AM +0200, Arun MURTHY wrote: > > On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > > > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-02 Thread Arun MURTHY
> On Wed, Oct 3, 2012 at 9:24 AM, Arun MURTHY > wrote: > >> On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > >> > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > >> > > > +#include > >> > > > +#include > >> > > > +#include > >> > > > +#include > >> > > > +#includ

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-02 Thread anish singh
On Wed, Oct 3, 2012 at 9:24 AM, Arun MURTHY wrote: >> On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: >> > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: >> > > > +#include >> > > > +#include >> > > > +#include >> > > > +#include >> > > > +#include >> > > > + >> >

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-02 Thread Arun MURTHY
> On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +static struct class *modem_class; > > > > > > What's wr

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-01 Thread Greg KH
On Mon, Oct 01, 2012 at 07:30:38AM +0200, Arun MURTHY wrote: > > On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +static struct class *modem_class; > > > > What's wrong with a bus_type i

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-01 Thread Arun MURTHY
> >> >> > +int modem_release(struct modem_desc *mdesc) { > >> >> > + if (!mdesc->release) > >> >> > + return -EFAULT; > >> >> > + > >> >> > + if (modem_is_requested(mdesc)) { > >> >> > + atomic_dec(&mdesc->mclients->cnt); > >> >> > + if (atomic_read(&mdesc->use_cnt

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-10-01 Thread anish singh
On Mon, Oct 1, 2012 at 12:27 PM, Arun MURTHY wrote: >> On Mon, Oct 1, 2012 at 11:00 AM, Arun MURTHY >> wrote: >> >> On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: >> >> > +#include >> >> > +#include >> >> > +#include >> >> > +#include >> >> > +#include >> >> > + >> >> > +static

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-09-30 Thread Arun MURTHY
> On Mon, Oct 1, 2012 at 11:00 AM, Arun MURTHY > wrote: > >> On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > + > >> > +static struct class *modem_class; > >> > >> What's wrong with a bus_t

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-09-30 Thread anish singh
On Mon, Oct 1, 2012 at 11:00 AM, Arun MURTHY wrote: >> On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +static struct class *modem_class; >> >> What's wrong with a bus_type instead? > > Can I k

RE: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-09-30 Thread Arun MURTHY
> On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +static struct class *modem_class; > > What's wrong with a bus_type instead? Can I know the advantage of using bus_type over class? > > > +static i

Re: [PATCHv4 1/4] modem_shm: Add Modem Access Framework

2012-09-28 Thread Greg KH
On Fri, Sep 28, 2012 at 01:35:01PM +0530, Arun Murthy wrote: > +#include > +#include > +#include > +#include > +#include > + > +static struct class *modem_class; What's wrong with a bus_type instead? > +static int __modem_is_requested(struct device *dev, void *data) > +{ > + struct modem