Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-07-02 Thread Morten Rasmussen
On Thu, Jun 28, 2018 at 07:16:46PM +0200, Dietmar Eggemann wrote: > On 06/28/2018 10:48 AM, Morten Rasmussen wrote: > >On Wed, Jun 27, 2018 at 05:41:22PM +0200, Dietmar Eggemann wrote: > >>On 06/22/2018 04:36 PM, Morten Rasmussen wrote: > >>>On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-28 Thread Dietmar Eggemann
On 06/28/2018 10:48 AM, Morten Rasmussen wrote: On Wed, Jun 27, 2018 at 05:41:22PM +0200, Dietmar Eggemann wrote: On 06/22/2018 04:36 PM, Morten Rasmussen wrote: On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: [...] What would happen if you hotplugged an entire cluster ? You

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-28 Thread Morten Rasmussen
On Wed, Jun 27, 2018 at 05:41:22PM +0200, Dietmar Eggemann wrote: > On 06/22/2018 04:36 PM, Morten Rasmussen wrote: > >On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: > >>Hi Morten, > >> > >>On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morten Rasmussen wrote: > >>>+static void upda

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-27 Thread Dietmar Eggemann
On 06/22/2018 04:36 PM, Morten Rasmussen wrote: On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: Hi Morten, On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morten Rasmussen wrote: +static void update_asym_cpucapacity(int cpu) +{ + int enable = false; + + rcu_read_lock(

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-22 Thread Morten Rasmussen
On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: > Hi Morten, > > On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morten Rasmussen wrote: > > +static void update_asym_cpucapacity(int cpu) > > +{ > > + int enable = false; > > + > > + rcu_read_lock(); > > + if (lowest_flag_domain(

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-22 Thread Quentin Perret
Hi Morten, On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morten Rasmussen wrote: > +static void update_asym_cpucapacity(int cpu) > +{ > + int enable = false; > + > + rcu_read_lock(); > + if (lowest_flag_domain(cpu, SD_ASYM_CPUCAPACITY)) > + enable = true; > + rcu_read_u