Re: [PATCHv3 1/1] mmc: core: export emmc revision

2017-10-20 Thread Ulf Hansson
On 12 October 2017 at 19:46, Jin Qian wrote: > From: Jin Qian > > Expose emmc revision as part of device attributes. > > Signed-off-by: Jin Qian Thanks, applied for next! Kind regards Uffe > --- > Documentation/ABI/testing/sysfs-bus-mmc | 4 > drivers/mmc/core/mmc.c | 2

Re: [PATCHv3 1/1] mmc: core: export emmc revision

2017-10-13 Thread Linus Walleij
On Thu, Oct 12, 2017 at 7:46 PM, Jin Qian wrote: > From: Jin Qian > > Expose emmc revision as part of device attributes. > > Signed-off-by: Jin Qian (...) > +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); This will be 0x on ordinary MMC cards right? Have you tested it? Yours, Linus Wal

Re: [PATCHv3 1/1] mmc: core: export emmc revision

2017-10-12 Thread Jisheng Zhang
On Thu, 12 Oct 2017 10:46:59 -0700 Jin Qian wrote: > From: Jin Qian > > Expose emmc revision as part of device attributes. > > Signed-off-by: Jin Qian > --- A trivial point: when you send newer version, could you add change log so that it's clearly expressed what's updated/addressed. > Docu