Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-09-16 Thread Ingo Molnar
* Mathias Krause wrote: > > Regardless of how it's implemented on the tooling side, my > > point remains: this kind of optimization is done on the > > tooling side in a natural fashion, while it's an ongoing > > maintenance concern on the kernel side. > > The costs of making the required cha

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-30 Thread Mathias Krause
On 22 August 2014 10:24, Ingo Molnar wrote: > > * Mathias Krause wrote: > >> > It feels like a burdensome hack that kernel developers are >> > forced to use different printing facilities, depending on >> > the life cycle of a method. We want to simplify init >> > annotations, we don't want to com

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-24 Thread Joe Perches
On Sun, 2014-08-24 at 18:04 +0200, Mathias Krause wrote: > On 21 August 2014 18:25, Sam Ravnborg wrote: > > So is it really worth it? > > I took the hacky script mentioned in the first email (now also > attached, init_str.awk), let it ran over the whole kernel, fixed the > fall-out and did an all

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-24 Thread Mathias Krause
On 21 August 2014 18:25, Sam Ravnborg wrote: > On Thu, Aug 21, 2014 at 02:23:03PM +0200, Mathias Krause wrote: >> This is v3 of the patch series initially posted here: >> >> https://lkml.org/lkml/2014/6/22/149 >> >> This series tries to address the problem of dangling strings of __init >> functi

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-22 Thread Ingo Molnar
* Mathias Krause wrote: > > It feels like a burdensome hack that kernel developers are > > forced to use different printing facilities, depending on > > the life cycle of a method. We want to simplify init > > annotations, we don't want to complicate them! > > Does this: > > pi_info("mk

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-21 Thread Sam Ravnborg
On Thu, Aug 21, 2014 at 02:23:03PM +0200, Mathias Krause wrote: > This is v3 of the patch series initially posted here: > > https://lkml.org/lkml/2014/6/22/149 > > This series tries to address the problem of dangling strings of __init > functions after initialization, as well as __exit strings

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-21 Thread Mathias Krause
On 21 August 2014 14:57, Ingo Molnar wrote: > > * Mathias Krause wrote: > >> This is v3 of the patch series initially posted here: >> >> https://lkml.org/lkml/2014/6/22/149 >> >> This series tries to address the problem of dangling strings of __init >> functions after initialization, as well as

Re: [PATCHv3 0/9] Mark literal strings in __init / __exit code

2014-08-21 Thread Ingo Molnar
* Mathias Krause wrote: > This is v3 of the patch series initially posted here: > > https://lkml.org/lkml/2014/6/22/149 > > This series tries to address the problem of dangling strings of __init > functions after initialization, as well as __exit strings for code not > even included in the f