On Wed, Jan 09, 2008 at 07:14:08AM +0100, Heiko Carstens wrote:
> I like this better (not including any other changes):
>
> if (!user_mode(regs) && !preemptible() && kprobe_running())
> return kprobe_fault_handler(regs, trapnr);
seconded.
--
To unsubscribe from this list: sen
On Tue, Jan 08, 2008 at 08:19:20PM -0800, Harvey Harrison wrote:
> Use a central kprobe_handle_fault() inline in kprobes.h to remove
> all of the arch-dependant, practically identical implementations in
> avr32, ia64, powerpc, s390, sparc64, and x86.
>
> avr32 was the only arch without the preempt
On Wed, 2008-01-09 at 07:14 +0100, Heiko Carstens wrote:
> > +/*
> > + * If it is a kprobe pagefault we can not be premptible so return before
>
> Missing 'e' in preemptible.
OK.
> However, the old code you removed had a lot of preempt_disable/enable calls
> that you removed. Hope you checked th
> +/*
> + * If it is a kprobe pagefault we can not be premptible so return before
Missing 'e' in preemptible.
However, the old code you removed had a lot of preempt_disable/enable calls
that you removed. Hope you checked that preemption was always disabled
already and the calls were not necessary
4 matches
Mail list logo
