Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-10 Thread One Thousand Gnomes
> Sounds good to me. The intention clearly was to point to the device in use, > which we can find then. I would concur. > I would not expect problems with this change. For common uses it is the > same name already and nothing visibly should change, and for the ones > where it isn't the same, I ex

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-07 Thread Kay Sievers
On Thu, Feb 6, 2014 at 5:29 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 06, 2014 at 04:44:20PM +0100, Hannes Reinecke wrote: >> On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: >> > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: >> >> The 'active' sysfs attribute should refer to

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 04:44:20PM +0100, Hannes Reinecke wrote: > On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: > > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: > >> The 'active' sysfs attribute should refer to the currently > >> active tty devices the console is running on

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Hannes Reinecke
On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: >> The 'active' sysfs attribute should refer to the currently >> active tty devices the console is running on, not the currently >> active console. > > That's not what Documentation

Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute

2014-02-06 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: > The 'active' sysfs attribute should refer to the currently > active tty devices the console is running on, not the currently > active console. That's not what Documentation/ABI/sysfs-tty says: Shows the list of cur