Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-20 Thread Dave Chinner
On Sat, May 19, 2018 at 08:56:39PM -0500, Steve French wrote: > On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > >> > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve F

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-19 Thread Steve French
On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: >> > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical >> > wrote: >> >> Patch updated with additi

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-19 Thread Dave Chinner
On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > > wrote: > >> Patch updated with additional tracepoint locations and some formatting > >> improveme

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-18 Thread Steve French
On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > wrote: >> Patch updated with additional tracepoint locations and some formatting >> improvements. There are some obvious additional tracepoints that could >> be adde

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-18 Thread Ralph Böhme
On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical wrote: > Patch updated with additional tracepoint locations and some formatting > improvements. There are some obvious additional tracepoints that could > be added, but this should be a reasonable group to start with. > >

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-18 Thread Steve French
On Fri, May 18, 2018 at 1:00 AM, ronnie sahlberg wrote: > Fair enough. > > Onto a second point then, for future patches. > > There are a lot of places where we do not (yet) pass a tcon as argument. > Can we make a policy decision to mandate that every tracepoint MUST > log tid, sid? > > And thus,

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-18 Thread ronnie sahlberg
Fair enough. Onto a second point then, for future patches. There are a lot of places where we do not (yet) pass a tcon as argument. Can we make a policy decision to mandate that every tracepoint MUST log tid, sid? And thus, if you need a new tracepoint in a function where tcon is not available y

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-17 Thread Steve French
On Thu, May 17, 2018 at 10:28 PM, Ronnie Sahlberg wrote: > Very nice. > > Acked-by: Ronnie Sahlberg > > Possibly change the output from > pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 > to > cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 > > just to make it easier for human-searching. I think the cmd will be useful

Re: [PATCHv2][SMB3] Add kernel trace support

2018-05-17 Thread Ronnie Sahlberg
Very nice. Acked-by: Ronnie Sahlberg Possibly change the output from pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 to cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 just to make it easier for human-searching. I think the cmd will be useful much more often than pid/tid/sid and this would make it easier to look f