Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-28 Thread Kirill A. Shutemov
Dave wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > > - BUG_ON(!PageAnon(page)); > > Did you really mean

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-22 Thread Dave
On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > +static int split_anon_huge_page(struct page *page) > { > struct anon_vma *anon_vma; > int ret = 1; > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > - BUG_ON(!PageAnon(page)); Did you really mean to kill these BUG_ON()s

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:26 PM, Kirill A. Shutemov wrote: > Hillf Danton wrote: >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov >> wrote: >> > -int split_huge_page(struct page *page) >> > +static int split_anon_huge_page(struct page *page) >> > { >> > struct anon_vma *anon_vma; >

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-15 Thread Kirill A. Shutemov
Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > -int split_huge_page(struct page *page) > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > -int split_huge_page(struct page *page) > +static int split_anon_huge_page(struct page *page) > { > struct anon_vma *anon_vma; > int ret = 1; > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > - BUG_ON(!Pag