Re: [PATCHv1 5/8] cgroup: introduce cgroup namespaces

2014-10-24 Thread Serge E. Hallyn
Quoting Aditya Kali (adityak...@google.com): > >> +void free_cgroup_ns(struct cgroup_namespace *ns) > >> +{ > >> + cgroup_put(ns->root_cgrp); > >> + put_user_ns(ns->user_ns); > > > > This is a problem on error patch in copy_cgroup_ns. The > > alloc_cgroup_ns() doesn't initialize these valu

Re: [PATCHv1 5/8] cgroup: introduce cgroup namespaces

2014-10-23 Thread Aditya Kali
I will include the suggested changes in the new patchset. Some comments inline. On Thu, Oct 16, 2014 at 9:37 AM, Serge E. Hallyn wrote: > Quoting Aditya Kali (adityak...@google.com): >> Introduce the ability to create new cgroup namespace. The newly created >> cgroup namespace remembers the 'stru

Re: [PATCHv1 5/8] cgroup: introduce cgroup namespaces

2014-10-16 Thread Serge E. Hallyn
Quoting Aditya Kali (adityak...@google.com): > Introduce the ability to create new cgroup namespace. The newly created > cgroup namespace remembers the 'struct cgroup *root_cgrp' at the point > of creation of the cgroup namespace. The task that creates the new > cgroup namespace and all its future