Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-10-01 Thread Tejun Heo
Hello, On Mon, Sep 30, 2013 at 11:03:50PM -0600, Bjorn Helgaas wrote: > I don't pretend to understand sysfs or the issue you tripped over with > PCI I/O BAR regions. But we had a long discussion about those files The issue is rather simple. Let's say I do "dd if=SOME_IO_BAR skip=12 bs=4 count=1

Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-09-30 Thread Bjorn Helgaas
On Sat, Sep 28, 2013 at 4:15 PM, Tejun Heo wrote: > Hey, again. > > On Sat, Sep 28, 2013 at 05:49:30PM -0400, Tejun Heo wrote: >> 0001-sysfs-remove-unused-sysfs_buffer-pos.patch >> 0002-sysfs-remove-sysfs_buffer-needs_read_fill.patch >> 0003-sysfs-remove-sysfs_buffer-ops.patch >> 0004-sysfs-ad

Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-09-30 Thread Greg KH
On Mon, Sep 30, 2013 at 03:54:03PM -0400, Tejun Heo wrote: > Hello, > > On Sat, Sep 28, 2013 at 06:15:13PM -0400, Tejun Heo wrote: > > On the second thought, 0011 seems too dangerous, especially for pci IO > > BAR regions. Grumble, looks like I'll have to break out the bin read > > path. Please

Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-09-30 Thread Tejun Heo
Hello, On Sat, Sep 28, 2013 at 06:15:13PM -0400, Tejun Heo wrote: > On the second thought, 0011 seems too dangerous, especially for pci IO > BAR regions. Grumble, looks like I'll have to break out the bin read > path. Please ignore patches >= 0009. I'll update them and repost. Please ignore th

Re: [PATCHSET] sysfs: use seq_file and unify regular and bin file handling

2013-09-28 Thread Tejun Heo
Hey, again. On Sat, Sep 28, 2013 at 05:49:30PM -0400, Tejun Heo wrote: > 0001-sysfs-remove-unused-sysfs_buffer-pos.patch > 0002-sysfs-remove-sysfs_buffer-needs_read_fill.patch > 0003-sysfs-remove-sysfs_buffer-ops.patch > 0004-sysfs-add-sysfs_open_file_mutex.patch > 0005-sysfs-rename-sysfs_buf