Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
On 02/07/2013 09:13 PM, Tim Gardner wrote: > Dynamically allocate the probe response template which > avoids potential stack corruption. Observed with smatch: > > drivers/net/wireless/brcm80211/brcmsmac/main.c:7412 > brcms_c_bss_update_probe_resp() > warn: 'prb_resp' puts 512 bytes on stack > >

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
On 02/07/2013 09:19 PM, Joe Perches wrote: > On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote: >> Dynamically allocate the probe response template which >> avoids potential stack corruption. Observed with smatch: > > trivial: > >> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c >

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Joe Perches
On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote: > Dynamically allocate the probe response template which > avoids potential stack corruption. Observed with smatch: trivial: > diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c > b/drivers/net/wireless/brcm80211/brcmsmac/main.c [] >