Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-16 Thread Ley Foon Tan
On Wed, Oct 14, 2015 at 9:32 PM, Arnd Bergmann wrote: > On Wednesday 14 October 2015 18:01:46 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 5:36 PM, Arnd Bergmann wrote: >> > On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: >> >> On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann wrote: >>

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Arnd Bergmann
On Wednesday 14 October 2015 18:01:46 Ley Foon Tan wrote: > On Wed, Oct 14, 2015 at 5:36 PM, Arnd Bergmann wrote: > > On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: > >> On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann wrote: > > > > Could we perhaps have a helper function that lets us r

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Ley Foon Tan
On Wed, Oct 14, 2015 at 5:36 PM, Arnd Bergmann wrote: > On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann wrote: >> > On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: >> >> On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann wrote: >>

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Arnd Bergmann
On Wednesday 14 October 2015 17:28:45 Ley Foon Tan wrote: > On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann wrote: > > On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: > >> On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann wrote: > >> > On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrot

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Ley Foon Tan
On Wed, Oct 14, 2015 at 5:09 PM, Arnd Bergmann wrote: > On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: >> On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann wrote: >> > On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote: >> >> +static int altera_pcie_remove(struct platform_device *pd

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Arnd Bergmann
On Wednesday 14 October 2015 16:32:25 Ley Foon Tan wrote: > On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann wrote: > > On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote: > >> +static int altera_pcie_remove(struct platform_device *pdev) > >> +{ > >> + struct altera_pcie *pcie = platform_g

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Ley Foon Tan
On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann wrote: > On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote: >> +static int altera_pcie_remove(struct platform_device *pdev) >> +{ >> + struct altera_pcie *pcie = platform_get_drvdata(pdev); >> + >> + altera_pcie_free_irq_domain(pcie); >

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-14 Thread Arnd Bergmann
On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote: > +static int altera_pcie_remove(struct platform_device *pdev) > +{ > + struct altera_pcie *pcie = platform_get_drvdata(pdev); > + > + altera_pcie_free_irq_domain(pcie); > + platform_set_drvdata(pdev, NULL); > + return 0; > +