RE: [PATCH v9 1/1] Add support for IPMB driver

2019-06-05 Thread Asmaa Mnebhi
-...@vger.kernel.org Subject: Re: [PATCH v9 1/1] Add support for IPMB driver Hi Asmaa, sorry for the long wait. I missed this mail was still sitting in my Drafts folder :( > >> Am I overlooking something? Why are you protecting an atomic_read with a > >> spinlock? > > A thread

Re: [PATCH v9 1/1] Add support for IPMB driver

2019-06-03 Thread Wolfram Sang
Hi Asmaa, sorry for the long wait. I missed this mail was still sitting in my Drafts folder :( > >> Am I overlooking something? Why are you protecting an atomic_read with a > >> spinlock? > > A thread would lock the ipmb_dev->lock spinlock (above) for all the code > below ONLY IF the atomic_re

RE: [PATCH v9 1/1] Add support for IPMB driver

2019-05-20 Thread Asmaa Mnebhi
-Original Message- From: Wolfram Sang Sent: Sunday, May 19, 2019 10:03 AM To: Asmaa Mnebhi Cc: miny...@acm.org; Vadim Pasternak ; Michael Shych ; rdun...@infradead.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v9 1/1] Add support for IPMB driver

Re: [PATCH v9 1/1] Add support for IPMB driver

2019-05-19 Thread Wolfram Sang
> +static int receive_ipmb_request(struct ipmb_dev *ipmb_dev, > + bool non_blocking, > + struct ipmb_msg *ipmb_request) > +{ > + struct ipmb_request_elem *queue_elem; > + unsigned long flags; > + int res; > + > + spin_lock_irq