Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-19 Thread Robin Murphy
On 2020-06-15 13:54, Syed Nayyar Waris wrote: This patch reimplements the xgpio_set_multiple function in drivers/gpio/gpio-xilinx.c to use the new for_each_set_clump macro. Instead of looping for each bit in xgpio_set_multiple function, now we can check each channel at a time and save cycles. Cc

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-19 Thread Luc Van Oostenryck
On Tue, Jun 16, 2020 at 11:27:18AM +0530, Syed Nayyar Waris wrote: Hi, > Regarding the compilation warning reported above: > > "sparse: shift too big (64) for type unsigned long" at line 639 > "sparse: invalid access past the end of 'old' (8 8)" at line 638 > > Kindly refer to the code above,

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-19 Thread Andy Shevchenko
On Fri, Jun 19, 2020 at 11:38:59AM +0300, Andy Shevchenko wrote: > On Fri, Jun 19, 2020 at 10:02 AM Syed Nayyar Waris > wrote: > > ... > > > > config: sparc64-randconfig-s032-20200615 (attached as .config) > > > compiler: sparc64-linux-gcc (GCC) 9.3.0 > > > reproduce: > > > # apt-get in

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-19 Thread Andy Shevchenko
On Fri, Jun 19, 2020 at 10:02 AM Syed Nayyar Waris wrote: ... > > config: sparc64-randconfig-s032-20200615 (attached as .config) > > compiler: sparc64-linux-gcc (GCC) 9.3.0 > > reproduce: > > # apt-get install sparse > > # sparse version: v0.6.2-rc1-3-g55607964-dirty > >

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-19 Thread Syed Nayyar Waris
> > Hi Syed, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on 444fc5cde64330661bf59944c43844e7d4c2ccd8] > > url: > https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20200615-205729 > base:444fc5cde6433

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-15 Thread Syed Nayyar Waris
On Tue, Jun 16, 2020 at 1:39 AM kernel test robot wrote: > > Hi Syed, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on 444fc5cde64330661bf59944c43844e7d4c2ccd8] > > url: > https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_eac

Re: [PATCH v8 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-06-15 Thread kernel test robot
Hi Syed, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 444fc5cde64330661bf59944c43844e7d4c2ccd8] url: https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20200615-205729 base:444fc5cde64330661bf59944c43844