Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-12 Thread David Collins
On 07/12/2018 09:54 AM, Mark Brown wrote: > On Mon, Jul 09, 2018 at 04:44:14PM -0700, David Collins wrote: >> On 07/02/2018 03:28 AM, Mark Brown wrote: >>> On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: +static unsigned int rpmh_regulator_pmic4_ldo_of_map_mode(unsigned int >>>

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-12 Thread Mark Brown
On Mon, Jul 09, 2018 at 04:44:14PM -0700, David Collins wrote: > On 07/02/2018 03:28 AM, Mark Brown wrote: > > On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: > >> +static const int pmic_mode_map_pmic4_ldo[REGULATOR_MODE_STANDBY + 1] = { > >> + [REGULATOR_MODE_INVALID] = -EINVAL, >

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-09 Thread David Collins
Hello Mark, On 07/02/2018 03:28 AM, Mark Brown wrote: > On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: > >> --- /dev/null >> +++ b/drivers/regulator/qcom-rpmh-regulator.c >> @@ -0,0 +1,746 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* Copyright (c) 2018, The Linux Foundation.

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-07-02 Thread Mark Brown
On Fri, Jun 22, 2018 at 05:46:14PM -0700, David Collins wrote: > --- /dev/null > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -0,0 +1,746 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */ > + Please make the entire header block

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-29 Thread Mark Brown
On Thu, Jun 28, 2018 at 11:04:17AM -0700, David Collins wrote: > Do you have any remaining concerns with the qcom-rpmh-regulator binding > and driver patches that would keep you from applying them (other than the > dependency patches being applied first)? To repeat I need to find the time to sit

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-28 Thread David Collins
Hello Mark, On 06/28/2018 03:18 AM, Mark Brown wrote: > On Wed, Jun 27, 2018 at 09:28:03AM -0700, Doug Anderson wrote: > >> OK, great. I guess I'm confused about the "|| COMPILE_TEST" causing >> problems then? I was worried that anyone trying to do "COMPILE_TEST" >> on your tree (or linuxnext i

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-28 Thread Mark Brown
On Wed, Jun 27, 2018 at 09:28:03AM -0700, Doug Anderson wrote: > OK, great. I guess I'm confused about the "|| COMPILE_TEST" causing > problems then? I was worried that anyone trying to do "COMPILE_TEST" > on your tree (or linuxnext if RPMh isn't there) would get failures due > to the lack of he

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-27 Thread Doug Anderson
Hi, On Wed, Jun 27, 2018 at 8:01 AM, Mark Brown wrote: > On Tue, Jun 26, 2018 at 11:15:14AM -0700, Doug Anderson wrote: > >> I think he's still planning on re-shuffling his tree a bit. When he >> does this, do you need him to put the RPMh patches somewhere you can >> merge into your tree? > > We

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-27 Thread Mark Brown
On Tue, Jun 26, 2018 at 11:15:14AM -0700, Doug Anderson wrote: > I think he's still planning on re-shuffling his tree a bit. When he > does this, do you need him to put the RPMh patches somewhere you can > merge into your tree? Well, I *think* there's no actual dependency here since it's a new d

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-26 Thread Doug Anderson
Hi, On Tue, Jun 26, 2018 at 8:02 AM, Mark Brown wrote: > On Tue, Jun 26, 2018 at 08:00:29AM -0700, Doug Anderson wrote: >> On Tue, Jun 26, 2018 at 5:07 AM, Mark Brown wrote: > >> > Please do not submit new versions of already applied patches, please >> > submit incremental updates to the existin

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-26 Thread Mark Brown
On Tue, Jun 26, 2018 at 08:00:29AM -0700, Doug Anderson wrote: > On Tue, Jun 26, 2018 at 5:07 AM, Mark Brown wrote: > > Please do not submit new versions of already applied patches, please > > submit incremental updates to the existing code. Modifying existing > > commits creates problems for ot

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-26 Thread Doug Anderson
Hi, On Tue, Jun 26, 2018 at 5:07 AM, Mark Brown wrote: > On Mon, Jun 25, 2018 at 11:50:52AM -0700, Doug Anderson wrote: > >> ...to this patch. Speaking of which it might be getting very close to >> time for this series to land along with David's other series, AKA: > >> * [1/2] regulator: of: add

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-26 Thread Mark Brown
On Mon, Jun 25, 2018 at 11:50:52AM -0700, Doug Anderson wrote: > ...to this patch. Speaking of which it might be getting very close to > time for this series to land along with David's other series, AKA: > * [1/2] regulator: of: add property for allowed modes specification > https://patchwork.

Re: [PATCH v8 2/2] regulator: add QCOM RPMh regulator driver

2018-06-25 Thread Doug Anderson
Hi, On Fri, Jun 22, 2018 at 5:46 PM, David Collins wrote: > Add the QCOM RPMh regulator driver to manage PMIC regulators > which are controlled via RPMh on some Qualcomm Technologies, Inc. > SoCs. RPMh is a hardware block which contains several > accelerators which are used to manage various har