Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-27 Thread Jason Gunthorpe
On Sat, Jun 25, 2016 at 06:47:45PM +0300, Jarkko Sakkinen wrote: > My repositories are ready for next pull request. The master has been > rebased to James' tree and merged to next. This seems fine.. Generally you shouldn't rebase to create pull requests, but this seemed needed.. Organize your g

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-25 Thread Jarkko Sakkinen
On Sat, Jun 25, 2016 at 06:24:30PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > > and not in my ma

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-25 Thread Jarkko Sakkinen
On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > and not in my master branch? > > I mean the stuff that is in your branch but not in main

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-24 Thread Jason Gunthorpe
On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > and not in my master branch? I mean the stuff that is in your branch but not in mainline. $ git log --pretty=oneline jarkko/master ^v4.7-rc3 | wc -l 73 > I'm

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-24 Thread Jarkko Sakkinen
On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hi Jason, > > On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > > if (expected > count) { > > > + dev_err(chip->pdev, "Response too long (wanted %z

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-24 Thread Jarkko Sakkinen
Hi Jason, On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > if (expected > count) { > > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > > + count, expected); > > This all

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

2016-06-24 Thread Jason Gunthorpe
> expected = be32_to_cpu(*(__be32 *) (buf + 2)); > if (expected > count) { > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > + count, expected); This all needs to be rebased on Jarkko's tree I guess, chip->pdev is gone now. http://gi