Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-15 Thread Thomas Gleixner
On Mon, 15 May 2017, Madhavan Srinivasan wrote: > On Wednesday 10 May 2017 05:39 PM, Thomas Gleixner wrote: > > On Thu, 4 May 2017, Anju T Sudhakar wrote: > > > + /* > > > + * Update the cpumask with the target cpu and > > > + * migrate the context if needed > > > + */ > > > + if (target >= 0 &&

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-15 Thread Madhavan Srinivasan
Sorry for delayed response. On Wednesday 10 May 2017 05:39 PM, Thomas Gleixner wrote: On Thu, 4 May 2017, Anju T Sudhakar wrote: +/* + * nest_init : Initializes the nest imc engine for the current chip. + * by default the nest engine is disabled. + */ +static void nest_init(int *cpu_opal_rc) +

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Madhavan Srinivasan
On Friday 12 May 2017 09:03 AM, Michael Ellerman wrote: Stewart Smith writes: Madhavan Srinivasan writes: * in patch 9 should opal_imc_counters_init return something other than OPAL_SUCCESS in the case on invalid arguments? Maybe OPAL_PARAMETER? (I think you fix this

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Madhavan Srinivasan
On Friday 12 May 2017 07:48 AM, Stewart Smith wrote: Madhavan Srinivasan writes: * in patch 9 should opal_imc_counters_init return something other than OPAL_SUCCESS in the case on invalid arguments? Maybe OPAL_PARAMETER? (I think you fix this in a later patch anyway?) S

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Michael Ellerman
Stewart Smith writes: > Madhavan Srinivasan writes: >>> * in patch 9 should opal_imc_counters_init return something other >>>than OPAL_SUCCESS in the case on invalid arguments? Maybe >>>OPAL_PARAMETER? (I think you fix this in a later patch anyway?) >> >> So, init call will

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Stewart Smith
Madhavan Srinivasan writes: >> * in patch 9 should opal_imc_counters_init return something other >>than OPAL_SUCCESS in the case on invalid arguments? Maybe >>OPAL_PARAMETER? (I think you fix this in a later patch anyway?) > > So, init call will return OPAL_PARAMETER for the u

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Thomas Gleixner
On Thu, 11 May 2017, Stephen Rothwell wrote: > Hi, > > On Wed, 10 May 2017 14:09:53 +0200 (CEST) Thomas Gleixner > wrote: > > > > > +static void nest_change_cpu_context(int old_cpu, int new_cpu) > > > +{ > > > + int i; > > > + > > > + for (i = 0; > > > + (per_nest_pmu_arr[i] != NULL) && (i

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-10 Thread Stephen Rothwell
Hi, On Wed, 10 May 2017 14:09:53 +0200 (CEST) Thomas Gleixner wrote: > > > +static void nest_change_cpu_context(int old_cpu, int new_cpu) > > +{ > > + int i; > > + > > + for (i = 0; > > +(per_nest_pmu_arr[i] != NULL) && (i < IMC_MAX_PMUS); i++) > > + perf_pmu_migrate_contex

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-10 Thread Thomas Gleixner
On Thu, 4 May 2017, Anju T Sudhakar wrote: > +/* > + * nest_init : Initializes the nest imc engine for the current chip. > + * by default the nest engine is disabled. > + */ > +static void nest_init(int *cpu_opal_rc) > +{ > + int rc; > + > + /* > + * OPAL figures out which CPU to start

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-09 Thread Anju T Sudhakar
Hi Daniel, On Monday 08 May 2017 07:42 PM, Daniel Axtens wrote: Hi all, I've had a look at the API as it was a big thing I didn't like in the earlier version. I am much happier with this one. Some comments: - I'm no longer subscribed to skiboot but I've had a look at the patches on th

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-08 Thread Madhavan Srinivasan
On Monday 08 May 2017 07:42 PM, Daniel Axtens wrote: Hi all, I've had a look at the API as it was a big thing I didn't like in the earlier version. I am much happier with this one. Thanks to mpe for suggesting this. :) Some comments: - I'm no longer subscribed to skiboot but I've had

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-08 Thread Daniel Axtens
Hi all, I've had a look at the API as it was a big thing I didn't like in the earlier version. I am much happier with this one. Some comments: - I'm no longer subscribed to skiboot but I've had a look at the patches on that side: * in patch 9 should opal_imc_counters_init return someth