Re: [PATCH v8] watchdog: New watchdog driver for MEN A21 watchdogs

2013-06-14 Thread Johannes Thumshirn
On Thu, Jun 13, 2013 at 08:55:33PM -0700, Guenter Roeck wrote: [...] > > Signed-off-by: Johannes Thumshirn > > Almost good. One comment below. > > Thanks, > Guenter > Nice to hear. Thanks for the review by the way. [...] > > + > > + drv->num_gpios = of_gpio_count(node); > > + if (drv->num_gp

Re: [PATCH v8] watchdog: New watchdog driver for MEN A21 watchdogs

2013-06-13 Thread Guenter Roeck
On Mon, Jun 03, 2013 at 04:34:59PM +0200, Johannes Thumshirn wrote: > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. > > Revision 2: > * Removed unneeded open flag in struct a21